Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ASSERT_TRUE when checking nullness in GTests #482

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Use ASSERT_TRUE when checking nullness in GTests #482

merged 1 commit into from
Apr 14, 2017

Conversation

sethfowler
Copy link
Contributor

Here's the fix for #480. Just a search and replace.

It's an unfortunate issue with GTest, especially since they did it deliberately, but it's not too bad to use ASSERT_TRUE for null checks instead.

@sethfowler sethfowler self-assigned this Apr 14, 2017
@sethfowler sethfowler merged commit c4fbb6c into p4lang:master Apr 14, 2017
@sethfowler sethfowler deleted the seth/use-assert-true-when-checking-for-non-null branch April 14, 2017 23:43
@fefer fefer mentioned this pull request Aug 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

Assignees

@sethfowler sethfowler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethfowler @mihaibudiu