Fix for issue #496 #500
Merged
Fix for issue #496 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix requires running the inlining pass repeatedly until convergence.
This fix also reinstates the removal of controls and parsers which are instantiated but never invoked. The inlining pass used to remove instantiations of inlined controls, but this was wrong, since some instantiations may have been used for other purposes as well (e.g., as arguments to other instantiations).
Perhaps the choice whether to remove or not unused instantiations should be subject to a compiler flag.
There are several conversions of comments to Doxygen.