#1004 Built-in auto-updates for core changes #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pH-7
changed the title
pH-7
force-pushed
the
GH-1004-easier-auto-updates
branch
from
85dbbfd
to
446a2e1
Compare
For when a new release is available :)
So, we now allow infinite time of execution (can still be disabled later :-))
Follow the guard clauses approach https://github.com/pH-7/GoodJsCode#guard-clauses-approach
Nitpick-CI
reviewed
Jun 11, 2022
| @@ -26,71 +27,62 @@ | |||
| use PH7\Framework\Security\Version; | |||
|
|
|||
| @set_time_limit(0); | |||
| @ini_set('max_execution_time','0'); // Infinite time of execution | |||
There was a problem hiding this comment.
No space found after comma in function call
…nto GH-1004-easier-auto-updates
pH-7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification & Information => #1004