Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range is not inclusive, so we must shift end by one #328

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Range is not inclusive, so we must shift end by one #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed13b9
Range is not inclusive, so we must shift end by one
pacak Oct 14, 2024
88fcb7f
And add tests for constants specifically
pacak Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check-and-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,12 @@ jobs:
- name: merged functions simd
shell: bash
if: ${{ !cancelled() && matrix.os != 'macos-latest' }} # uses x86 primops
run: ./.github/check.sh --manifest-path sample_merged/Cargo.toml sample_merged::merged_0
run: ./.github/check.sh --manifest-path sample_merged/Cargo.toml sample_merged::merged_0 --include-constants

- name: merged functions simd
shell: bash
if: ${{ !cancelled() && matrix.os != 'macos-latest' }} # uses x86 primops
run: ./.github/check.sh --manifest-path sample_merged/Cargo.toml sample_merged::merged_1
run: ./.github/check.sh --manifest-path sample_merged/Cargo.toml sample_merged::merged_1 --include-constants

- name: merged functions extern c
shell: bash
Expand Down
3 changes: 2 additions & 1 deletion src/asm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ fn scan_constant(
+ body[start + 1..]
.iter()
.take_while(|s| matches!(s, Statement::Directive(Directive::Data(_, _))))
.count();
.count()
+ 1;
Some(URange { start, end })
}

Expand Down
Loading