From ca06d46d329d93f7e65d9277629bdf88dd32a950 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 13 Oct 2023 14:59:45 +0200 Subject: [PATCH] fix(deps): update glide to v4.16.0 (#123) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.github.bumptech.glide:okhttp3-integration](https://togithub.com/bumptech/glide) | `4.15.1` -> `4.16.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.github.bumptech.glide:okhttp3-integration/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.github.bumptech.glide:okhttp3-integration/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.github.bumptech.glide:okhttp3-integration/4.15.1/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.github.bumptech.glide:okhttp3-integration/4.15.1/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [com.github.bumptech.glide:glide](https://togithub.com/bumptech/glide) | `4.15.1` -> `4.16.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.github.bumptech.glide:glide/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.github.bumptech.glide:glide/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.github.bumptech.glide:glide/4.15.1/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.github.bumptech.glide:glide/4.15.1/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [com.github.bumptech.glide:ksp](https://togithub.com/bumptech/glide) | `4.15.1` -> `4.16.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.github.bumptech.glide:ksp/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.github.bumptech.glide:ksp/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.github.bumptech.glide:ksp/4.15.1/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.github.bumptech.glide:ksp/4.15.1/4.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes
bumptech/glide (com.github.bumptech.glide:okhttp3-integration) ### [`v4.16.0`](https://togithub.com/bumptech/glide/releases/tag/v4.16.0): Glide 4.16.0 This release focuses on some build improvements and Compose. The two major Compose improvements are adding support for Compose specific transitions (e.g. cross fade) and supporting recomposition based on request state using `GlideSubcomposition`. There's also been a bunch of internal refactoring to move away from Painters to Modifier nodes based on feedback from the Compose team. This is still an alpha release of Compose, but barring unexpectedly negative feedback, the next release should be beta. This should be the last release of Glide that targets Java 7. That probably means our next release will be a major version change. ##### Features - Allow passing an executor into ChromiumRequestSerializer in [https://github.com/bumptech/glide/pull/5077](https://togithub.com/bumptech/glide/pull/5077) - Allow host app to provide a way to clear all resources onStop() by [@​osamaaftab](https://togithub.com/osamaaftab) in [https://github.com/bumptech/glide/pull/5145](https://togithub.com/bumptech/glide/pull/5145) ##### Compose - Add a Transition API and a CrossFade Transition for Compose by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5235](https://togithub.com/bumptech/glide/pull/5235) - Influence layout using intrinsics in GlideNode by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5240](https://togithub.com/bumptech/glide/pull/5240) \* Log instead of throwing parsing manifests to fix compose previews by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5167](https://togithub.com/bumptech/glide/pull/5167) - Launch no more than one request per onRemembered by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5062](https://togithub.com/bumptech/glide/pull/5062) - Remove GlidePainter in favor of Modifier nodes / Flows by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5230](https://togithub.com/bumptech/glide/pull/5230) - Replace flows in GlideSubcomposition with a listener on GlideNode by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5238](https://togithub.com/bumptech/glide/pull/5238) ##### Bugs - Read library glide module names from Java indexes by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5052](https://togithub.com/bumptech/glide/pull/5052) - Fix typo. anay -> any in GlideSymbolProcessor.kt. by [@​trevorhackman](https://togithub.com/trevorhackman) in [https://github.com/bumptech/glide/pull/5029](https://togithub.com/bumptech/glide/pull/5029) - Include URL in error log by [@​paulsowden](https://togithub.com/paulsowden) in [https://github.com/bumptech/glide/pull/5164](https://togithub.com/bumptech/glide/pull/5164) - Add `isInitialized` visible for testing method by [@​paulsowden](https://togithub.com/paulsowden) in [https://github.com/bumptech/glide/pull/5163](https://togithub.com/bumptech/glide/pull/5163) - Use onIdle to avoid a race in FlowTests by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5202](https://togithub.com/bumptech/glide/pull/5202) - Add a isEquivalentTo method to correctly check equality by [@​mori-atsushi](https://togithub.com/mori-atsushi) in [https://github.com/bumptech/glide/pull/5232](https://togithub.com/bumptech/glide/pull/5232) - Add [@​RequiresPermission](https://togithub.com/RequiresPermission) to NotificationTarget by [@​TWiStErRob](https://togithub.com/TWiStErRob) in [https://github.com/bumptech/glide/pull/5220](https://togithub.com/bumptech/glide/pull/5220) ##### Deprecations - `placeholderOf(@​Composable)` in `GlideImage` is deprecated, use `GlideSubcomposition` instead. Keep in mind that using either forces a recomposition each time the state of the image load changes. Recomposition will have a significant performance penalty in scrolling lists and should be avoided. ##### Behavior Changes - Hard code disabling hardware bitmaps on O/OMR1. by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5115](https://togithub.com/bumptech/glide/pull/5115) - Do not set requireOriginal on Android photo picker uris. by [@​phoenixli](https://togithub.com/phoenixli) in [https://github.com/bumptech/glide/pull/5162](https://togithub.com/bumptech/glide/pull/5162) ##### Breaking Changes ##### Build Changes - Add integration tests for ksp library modules. by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5054](https://togithub.com/bumptech/glide/pull/5054) - Update README.md to use https by [@​simoarpe](https://togithub.com/simoarpe) in [https://github.com/bumptech/glide/pull/5058](https://togithub.com/bumptech/glide/pull/5058) - Use dokka to build scripts/update_javadocs.sh by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5104](https://togithub.com/bumptech/glide/pull/5104) - avif integration: Update libavif dependency by [@​vigneshvg](https://togithub.com/vigneshvg) in [https://github.com/bumptech/glide/pull/5128](https://togithub.com/bumptech/glide/pull/5128) - Disable java 7 source obsolete warning. by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5168](https://togithub.com/bumptech/glide/pull/5168) - Update mockito version to fix j16 compilation. by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5169](https://togithub.com/bumptech/glide/pull/5169) - Switch Glide's dependencies to a version catalog. by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5183](https://togithub.com/bumptech/glide/pull/5183) - Remove jetifier by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5184](https://togithub.com/bumptech/glide/pull/5184) - Add an updated proguard plugin to compile on Java 17. by [@​sjudd](https://togithub.com/sjudd) in [https://github.com/bumptech/glide/pull/5185](https://togithub.com/bumptech/glide/pull/5185) - Configure Renovate in [https://github.com/bumptech/glide/pull/5186](https://togithub.com/bumptech/glide/pull/5186) - Increment ROBOLECTRIC_SDK to 19 from 18. by [@​brettchabot](https://togithub.com/brettchabot) in [https://github.com/bumptech/glide/pull/5208](https://togithub.com/bumptech/glide/pull/5208) and [https://github.com/bumptech/glide/pull/5207](https://togithub.com/bumptech/glide/pull/5207) - AGP: Upgrade AndroidManifest.xml's package to build.gradle's namespace. by [@​TWiStErRob](https://togithub.com/TWiStErRob) in [https://github.com/bumptech/glide/pull/5221](https://togithub.com/bumptech/glide/pull/5221) ##### New Contributors - [@​trevorhackman](https://togithub.com/trevorhackman) made their first contribution in [https://github.com/bumptech/glide/pull/5029](https://togithub.com/bumptech/glide/pull/5029) - [@​simoarpe](https://togithub.com/simoarpe) made their first contribution in [https://github.com/bumptech/glide/pull/5058](https://togithub.com/bumptech/glide/pull/5058) - [@​paulsowden](https://togithub.com/paulsowden) made their first contribution in [https://github.com/bumptech/glide/pull/5164](https://togithub.com/bumptech/glide/pull/5164) - [@​phoenixli](https://togithub.com/phoenixli) made their first contribution in [https://github.com/bumptech/glide/pull/5162](https://togithub.com/bumptech/glide/pull/5162) - [@​osamaaftab](https://togithub.com/osamaaftab) made their first contribution in [https://github.com/bumptech/glide/pull/5145](https://togithub.com/bumptech/glide/pull/5145) - [@​brettchabot](https://togithub.com/brettchabot) made their first contribution in [https://github.com/bumptech/glide/pull/5207](https://togithub.com/bumptech/glide/pull/5207) - [@​mori-atsushi](https://togithub.com/mori-atsushi) made their first contribution in [https://github.com/bumptech/glide/pull/5232](https://togithub.com/bumptech/glide/pull/5232) **Full Changelog**: https://github.com/bumptech/glide/compare/v4.15.0...v4.16.0 Note - there's been a change in the gpg key used to sign these releases. The new public key is attached
--- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Nik Clayton --- .../app/pachli/components/compose/dialog/FocusDialog.kt | 6 +++--- app/src/main/java/app/pachli/fragment/ViewImageFragment.kt | 2 +- app/src/main/java/app/pachli/view/MediaPreviewImageView.kt | 4 ++-- gradle/libs.versions.toml | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/app/pachli/components/compose/dialog/FocusDialog.kt b/app/src/main/java/app/pachli/components/compose/dialog/FocusDialog.kt index 050b1a8de..f740081c6 100644 --- a/app/src/main/java/app/pachli/components/compose/dialog/FocusDialog.kt +++ b/app/src/main/java/app/pachli/components/compose/dialog/FocusDialog.kt @@ -50,12 +50,12 @@ fun T.makeFocusDialog( .downsample(DownsampleStrategy.CENTER_INSIDE) .listener( object : RequestListener { - override fun onLoadFailed(p0: GlideException?, p1: Any?, p2: Target?, p3: Boolean): Boolean { + override fun onLoadFailed(p0: GlideException?, p1: Any?, p2: Target, p3: Boolean): Boolean { return false } - override fun onResourceReady(resource: Drawable?, model: Any?, target: Target?, dataSource: DataSource?, isFirstResource: Boolean): Boolean { - val width = resource!!.intrinsicWidth + override fun onResourceReady(resource: Drawable, model: Any, target: Target?, dataSource: DataSource, isFirstResource: Boolean): Boolean { + val width = resource.intrinsicWidth val height = resource.intrinsicHeight dialogBinding.focusIndicator.setImageSize(width, height) diff --git a/app/src/main/java/app/pachli/fragment/ViewImageFragment.kt b/app/src/main/java/app/pachli/fragment/ViewImageFragment.kt index 56db5fc4e..ac26d0dd7 100644 --- a/app/src/main/java/app/pachli/fragment/ViewImageFragment.kt +++ b/app/src/main/java/app/pachli/fragment/ViewImageFragment.kt @@ -310,7 +310,7 @@ class ViewImageFragment : ViewMediaFragment() { override fun onLoadFailed( e: GlideException?, - model: Any, + model: Any?, target: Target, isFirstResource: Boolean, ): Boolean { diff --git a/app/src/main/java/app/pachli/view/MediaPreviewImageView.kt b/app/src/main/java/app/pachli/view/MediaPreviewImageView.kt index db85454df..f2b340b9a 100644 --- a/app/src/main/java/app/pachli/view/MediaPreviewImageView.kt +++ b/app/src/main/java/app/pachli/view/MediaPreviewImageView.kt @@ -96,11 +96,11 @@ open class MediaPreviewImageView } } - override fun onLoadFailed(e: GlideException?, model: Any?, target: Target?, isFirstResource: Boolean): Boolean { + override fun onLoadFailed(e: GlideException?, model: Any?, target: Target, isFirstResource: Boolean): Boolean { return false } - override fun onResourceReady(resource: Drawable?, model: Any?, target: Target?, dataSource: DataSource?, isFirstResource: Boolean): Boolean { + override fun onResourceReady(resource: Drawable, model: Any, target: Target?, dataSource: DataSource, isFirstResource: Boolean): Boolean { recalculateMatrix(width, height, resource) return false } diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index b99aaddde..b6d16819e 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -31,7 +31,7 @@ diffx = "1.1.1" emoji2 = "1.3.0" espresso = "3.5.1" filemoji-compat = "3.2.7" -glide = "4.15.1" +glide = "4.16.0" # Deliberate downgrade, https://github.com/tuskyapp/Tusky/issues/3631 glide-animation-plugin = "2.23.0" gson = "2.10.1"