Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare and refactor events/parsers for CentOS Stream dist-git comments #2471

Open
8 tasks
Tracked by #2191
mfocko opened this issue Jul 18, 2024 · 0 comments · May be fixed by #2590
Open
8 tasks
Tracked by #2191

Prepare and refactor events/parsers for CentOS Stream dist-git comments #2471

mfocko opened this issue Jul 18, 2024 · 0 comments · May be fixed by #2590
Assignees
Labels
area/rhel-ecosystem RHEL & CentOS stream CentOS Stream Work related to CentOS Stream. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/refactor Technical debt - the code needs love.

Comments

@mfocko
Copy link
Member

mfocko commented Jul 18, 2024

TODO

  • Decide whether it makes sense to have duplicitous “events” for GitLab (downstream and upstream), or handle them in a similar way as @majamassarini did with the mixins (common GitLab part, common downstream/upstream part), although I'm not sure how feasible it is to use mixins here 🤔
  • Refactor parsing of GitLab events (since there will be upstream events directly via GitLab webhook and downstream events provided via Fedora Messaging)
  • Parse the dist-git GitLab events (example of such event)
  • Revamp the hierarchy for dist-git events, if necessary (afterwards the events will be coming from both GitLab and Pagure)

ACs

  • There is a one parser for each GitLab event, e.g., parsing of a push to either upstream on GitLab or downstream on GitLab should be parsed by one function only, there should be no duplication present that would differentiate upstream from downstream on the parsing level.
  • Downstream events should have common ancestors that allow handlers to be handling just one ancestor for downstream.
    i.e. there should be a notion of a dist-git event in general (such as AbstractDownstreamEvent) and more specific ones (such as AbstractDownstreamPushEvent)
  • Current downstream workflows must not be broken.
  • Current upstream workflows on GitLab must not be broken.

Links

Part of #2191

@mfocko mfocko moved this from new to priority-backlog in Packit Kanban Board Jul 18, 2024
@mfocko mfocko added CentOS Stream Work related to CentOS Stream. complexity/single-task Regular task, should be done within days. kind/refactor Technical debt - the code needs love. impact/high This issue impacts multiple/lot of users. gain/high This brings a lot of value to (not strictly a lot of) users. area/rhel-ecosystem RHEL & CentOS stream labels Jul 18, 2024
@mfocko mfocko self-assigned this Oct 8, 2024
@mfocko mfocko moved this from refined to in-progress in Packit Kanban Board Oct 8, 2024
@mfocko mfocko linked a pull request Nov 18, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rhel-ecosystem RHEL & CentOS stream CentOS Stream Work related to CentOS Stream. complexity/single-task Regular task, should be done within days. gain/high This brings a lot of value to (not strictly a lot of) users. impact/high This issue impacts multiple/lot of users. kind/refactor Technical debt - the code needs love.
Projects
Status: in-progress
1 participant