chore: terminate child processes on windows

pact-foundation · Aug 21, 2024 · f332bca · f332bca
1 parent 4c163f4
commit f332bca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/drivers/rust/driver/src/child_process.rs b/drivers/rust/driver/src/child_process.rs
@@ -115,7 +115,10 @@ impl ChildPluginProcess {
  let mut s = System::new();
  s.refresh_processes();
  if let Some(process) = s.process(Pid::from_u32(self.child_pid as u32)) {
+ #[cfg(not(windows))]
  process.kill();
+ #[cfg(windows)]
+ process::Command::new("taskkill.exe").arg("/PID").arg(child_pid.to_string()).arg("/F").arg("/T").output();
  } else {
  warn!("Child process with PID {} was not found", self.child_pid);
  }

diff --git a/drivers/rust/driver/src/plugin_manager.rs b/drivers/rust/driver/src/plugin_manager.rs
@@ -284,7 +284,10 @@ async fn start_plugin_process(manifest: &PactPluginManifest) -> anyhow::Result<P
  let mut s = System::new();
  s.refresh_processes();
  if let Some(process) = s.process(Pid::from_u32(child_pid)) {
+ #[cfg(not(windows))]
  process.kill();
+ #[cfg(windows)]
+ process::Command::new("taskkill.exe").arg("/PID").arg(child_pid.to_string()).arg("/F").arg("/T").creation_flags(CREATE_NO_WINDOW.0).output();
  } else {
  warn!("Child process with PID {} was not found", child_pid);
  }