From ab3f9a567db4abdbf5e0ca4013e672e81d632aff Mon Sep 17 00:00:00 2001
From: Ronald Holshausen <ronald.holshausen@smartbear.com>
Date: Thu, 21 Dec 2023 15:18:31 +1100
Subject: [PATCH] fix(verifier): default error formatter does not display the
 inner error #351

---
 rust/pact_verifier/src/lib.rs     |   5 +-
 rust/pact_verifier/tests/tests.rs | 112 ++++++++++++++++++++++++++++++
 2 files changed, 115 insertions(+), 2 deletions(-)

diff --git a/rust/pact_verifier/src/lib.rs b/rust/pact_verifier/src/lib.rs
index 2465e43fd..993e4cfcc 100644
--- a/rust/pact_verifier/src/lib.rs
+++ b/rust/pact_verifier/src/lib.rs
@@ -1097,8 +1097,9 @@ pub async fn verify_provider_async<F: RequestFilterExecutor, S: ProviderStateExe
               warn!("Ignoring no pacts error - {}", Yellow.paint(err.to_string()));
             }
           } else {
-            error!("Failed to load pact - {}", Red.paint(err.to_string()));
-            errors.push(("Failed to load pact".to_string(), MismatchResult::Error(err.to_string(), None)));
+            let error = format!("{:#}", err);
+            error!("Failed to load pact - {}", Red.paint(error.clone()));
+            errors.push(("Failed to load pact".to_string(), MismatchResult::Error(error, None)));
           }
         }
       }
diff --git a/rust/pact_verifier/tests/tests.rs b/rust/pact_verifier/tests/tests.rs
index bca451df6..4af7094e8 100644
--- a/rust/pact_verifier/tests/tests.rs
+++ b/rust/pact_verifier/tests/tests.rs
@@ -836,3 +836,115 @@ async fn verify_pact_with_matcher_on_last_modified_header() {
 
   expect!(result.unwrap().results.get(0).unwrap().result.as_ref()).to(be_ok());
 }
+
+// Issue #351
+#[test_log::test(tokio::test)]
+async fn broker_validation_errors_should_be_shown_to_the_user() {
+  let server = PactBuilderAsync::new("RustPactVerifier", "PactBrokerTest2")
+    .interaction("a request to the pact broker root", "", |mut i| async move {
+      i.request
+        .path("/")
+        .header("Accept", "application/hal+json")
+        .header("Accept", "application/json");
+      i.response
+        .header("Content-Type", "application/hal+json")
+        .json_body(json_pattern!({
+            "_links": {
+                "pb:provider-pacts-for-verification": {
+                  "href": like!("http://localhost/pacts/provider/{provider}/for-verification"),
+                  "title": like!("Pact versions to be verified for the specified provider"),
+                  "templated": like!(true)
+                }
+            }
+        }));
+      i
+    })
+    .await
+    .interaction("a request to the pacts for verification endpoint", "", |mut i| async move {
+      i.request
+        .get()
+        .path("/pacts/provider/Alice%20Service/for-verification")
+        .header("Accept", "application/hal+json")
+        .header("Accept", "application/json");
+      i.response
+        .header("Content-Type", "application/hal+json")
+        .json_body(json_pattern!({
+                "_links": {
+                    "self": {
+                      "href": like!("http://localhost/pacts/provider/Alice%20Service/for-verification"),
+                      "title": like!("Pacts to be verified")
+                    }
+                }
+            }));
+      i
+    })
+    .await
+    .interaction("a request for the pacts to verify", "", |mut i| async move {
+      i.request
+        .post()
+        .path("/pacts/provider/Alice%20Service/for-verification")
+        .header("Accept", "application/hal+json")
+        .header("Accept", "application/json");
+      i.response
+        .status(400)
+        .header("Content-Type", "application/hal+json")
+        .json_body("[\"consumerVersionSelectors: cannot specify the fields branch/latest with the field deployedOrReleased (at index 0)\"]");
+      i
+    })
+    .await
+    .start_mock_server(None);
+
+  #[allow(deprecated)]
+    let provider_info = ProviderInfo {
+    name: "Alice Service".to_string(),
+    host: "127.0.0.1".to_string(),
+    port: Some(8080),
+    transports: vec![ ProviderTransport {
+      transport: "HTTP".to_string(),
+      port: Some(8080),
+      path: None,
+      scheme: Some("http".to_string())
+    } ],
+    .. ProviderInfo::default()
+  };
+
+  let pact_source = PactSource::BrokerWithDynamicConfiguration {
+    provider_name: "Alice Service".to_string(),
+    broker_url: server.url().to_string(),
+    enable_pending: false,
+    include_wip_pacts_since: None,
+    provider_tags: vec![],
+    provider_branch: None,
+    selectors: vec![],
+    auth: None,
+    links: vec![]
+  };
+
+  let verification_options: VerificationOptions<NullRequestFilterExecutor> = VerificationOptions::default();
+  let provider_state_executor = Arc::new(DummyProviderStateExecutor{});
+  let publish_options = PublishOptions {
+    provider_version: Some("1.2.3".to_string()),
+    build_url: None,
+    provider_tags: vec![],
+    provider_branch: None,
+  };
+
+  let result = verify_provider_async(
+    provider_info,
+    vec![ pact_source ],
+    FilterInfo::None,
+    vec![ "Consumer".to_string() ],
+    &verification_options,
+    Some(&publish_options),
+    &provider_state_executor,
+    None
+  ).await;
+
+  let verification_result = result.unwrap();
+  expect!(verification_result.result).to(be_false());
+  let error = &verification_result.errors[0].1;
+  let error_json: Value = error.into();
+  let message = error_json.as_object().unwrap().get("message").unwrap();
+  let message_str = message.to_string();
+  expect!(message_str.contains("consumerVersionSelectors: cannot specify the fields branch/latest with the field deployedOrReleased (at index 0)")).to(be_true());
+}