Wrap <li> in <ul>, not directly in <nav>. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<li> must now be used in <nav>, this yields a HTML validator violation otherwise. So wrap it in <ul> and remove any effects of the <ul>.
parkr
approved these changes
Jul 15, 2021
|
Thank you so much! |
|
Congrats on getting your first pull request to the Midnight theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
Thank you for coming back and checking the PRs, it's good to see the project is still alive 👍 . |
mikeconley
added a commit
to mikeconley/joy-of-coding-episode-guide
that referenced
this pull request
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<li>must now be used in<nav>, this yields a HTMLvalidator violation otherwise.
So wrap it in
<ul>and remove any effects of the<ul>.