Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DMSF 1.6 feature "DMSF files act as attachable on issues" #53

Closed
tofi86 opened this issue Apr 21, 2018 · 10 comments
Closed
Assignees
Milestone

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Apr 21, 2018

@dinya request in #40 (comment):

Redmine DMSF 1.6.x allows documents attachements to issue.

Is it doable to add preview thumbnails of DMS section with preview lightbox?

@tofi86
Copy link
Collaborator Author

tofi86 commented Apr 21, 2018

I will add support for this feature in master branch for Redmine 3.4.

Is Redmine 3.3 support also requested?

@tofi86 tofi86 closed this as completed in 3cf5d60 Apr 21, 2018
@tofi86 tofi86 added this to the Version 0.4.4 milestone Apr 21, 2018
@tofi86 tofi86 self-assigned this Apr 21, 2018
@tofi86
Copy link
Collaborator Author

tofi86 commented Apr 21, 2018

@dinya: please test the current master branch with Redmine 3.4 and tell me whether it works as expected.

my tests have been successfull and I also added rel attribute so you can have a slideshow of all dmsf thumbnails (use arrow keys or icons beside the lightbox image).

@dinya
Copy link

dinya commented Apr 22, 2018

Is Redmine 3.3 support also requested?

DMSF 1.6.x works with Redmine 3.4 only. So no.

Thanks. I will test current master on Monday.

@dinya
Copy link

dinya commented Apr 23, 2018

@tofi86

Lightbox is works well, but:

  1. There are no thumbnails after titles like for "classic" attachments. (BTW, maybe add option in settings to either show or not thumbnails both in attachments and in DMS content.)

no_thumbnails

  1. DMS titles are not shown in a lightbox:

caption from dms

@dinya
Copy link

dinya commented May 3, 2018

Dear @tofi86

Do you have any ideas?

@tofi86
Copy link
Collaborator Author

tofi86 commented May 3, 2018

@dinya sorry, I'm currently on parental leave with a newborn and not checking open source projects regularly.

In my case, thumbnails are shown, probably because I enabled thumbnail generation in redmine settings?
I can try to add thumbnails even if this feature is turned off, like I do with the normal image attachments. will see...

About the description: you're right. I will try to take a look soon.

@tofi86 tofi86 reopened this May 3, 2018
@dinya
Copy link

dinya commented May 3, 2018

@tofi86

I'm currently on parental leave with a newborn

My sincere congratulations! :-)

In my case, thumbnails are shown, probably because I enabled thumbnail generation in redmine settings?

You are right: I'm enable this and it works as expected (I never used this feature before).

@tofi86
Copy link
Collaborator Author

tofi86 commented May 3, 2018

Thanks! 😊

Glad it works for you! Nevertheless, I will try to find a solution similar to the image attachements.

@tofi86
Copy link
Collaborator Author

tofi86 commented Nov 2, 2019

Fixed with 8e8dc02 for Redmine 3.4.

Bildschirmfoto 2019-11-02 um 19 46 55

Redmine 4 support will be available once the Redmine 3 compatible version has been released and merged to the Redmine 4 compatible version.

tofi86 added a commit that referenced this issue Nov 2, 2019
@tofi86
Copy link
Collaborator Author

tofi86 commented Nov 2, 2019

Redmine 4 support on master was added.

@tofi86 tofi86 closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants