Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide preview in DMSF folder #64

Closed
dinya opened this issue Apr 30, 2019 · 5 comments
Closed

Slide preview in DMSF folder #64

dinya opened this issue Apr 30, 2019 · 5 comments
Assignees
Milestone

Comments

@dinya
Copy link

dinya commented Apr 30, 2019

Hello @tofi86

When we are on the issue page containing DMS objects the lightbox2 allows to preview objects in slide mode (Previous/Next buttons are availiable in Preview mode).

It will be very cool if the lightbox2 will allow to preview images from DMSF folder page.

dmsf_folder

@tofi86
Copy link
Collaborator

tofi86 commented Sep 25, 2019

Added and tested for Redmine 3.4 on branch redmine-3.4.

Added and tested for Redmine 4.0 on branch master.

No new version has been released yet.

@dinya Could you please test the latest version from master branch in Redmine 4? Is this what you expected?

Unfortunately I couldn't get it working for PDF previews, although it works for PDF previews in wiki pages. I have no idea what's wrong. So for the moment I'll skip PDF preview in the DMS browser page.

@tofi86 tofi86 added this to the Next release milestone Sep 25, 2019
@tofi86 tofi86 self-assigned this Sep 25, 2019
@dinya
Copy link
Author

dinya commented Sep 29, 2019

@tofi86

Good job! 👍 Thanks a lot.

I tested the plugin with redmine-3.4. But I have plans for migration to redmine-4 soon. And redmine_lightbox2 will be tested at the same time.

@tofi86
Copy link
Collaborator

tofi86 commented Sep 29, 2019

Perfect, thanks! Closing this as solved :-)

@tofi86 tofi86 closed this as completed Sep 29, 2019
@dinya
Copy link
Author

dinya commented Oct 6, 2019

@tofi86

Could you add dmsf file ID to image label (something like [<id>] <title>)?

Use case. I found the image of interest in the slide preview and wanna link to it in some issue or wiki page with {{dmsftn(id)}}.

Currently I should remember the title (label), close preview and find ID by title in the files list. And then I can add the link. But the ID presence in the label in the bottom prevents this three unnecessary steps (remember, close and find).

What do you think?

@tofi86
Copy link
Collaborator

tofi86 commented Nov 2, 2019

What do you think?

See #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants