Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMSF support: add id to image label #73

Closed
tofi86 opened this issue Nov 2, 2019 · 5 comments
Closed

DMSF support: add id to image label #73

tofi86 opened this issue Nov 2, 2019 · 5 comments
Assignees
Milestone

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Nov 2, 2019

From @dinya at #64 (comment):

@tofi86

Could you add dmsf file ID to image label (something like [<id>] <title>)?

Use case. I found the image of interest in the slide preview and wanna link to it in some issue or wiki page with {{dmsftn(id)}}.

Currently I should remember the title (label), close preview and find ID by title in the files list. And then I can add the link. But the ID presence in the label in the bottom prevents this three unnecessary steps (remember, close and find).

What do you think?

@tofi86
Copy link
Collaborator Author

tofi86 commented Nov 2, 2019

grafik

Support added for both Redmine 4 (branch master) and Redmine 3.4 (branch redmine-3.4).

@dinya
Copy link

dinya commented Nov 5, 2019

@tofi86

I updated with the current redmine-3.4 branch, but there is no ID in the image label (DMS tab),

изображение

Label with dmsf id is ok in the issue page (like on your screenshot above).

My env:

Item Version
Redmine version 3.4.11.stable
Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux]
redmine_lightbox2 0.4.5
redmine_dmsf 1.6.2

@tofi86
Copy link
Collaborator Author

tofi86 commented Nov 5, 2019

Did you run the plugin migrations?

@dinya
Copy link

dinya commented Nov 5, 2019

Yes, as usual with

bundle exec rake redmine:plugins:migrate RAILS_ENV="production"

@tofi86
Copy link
Collaborator Author

tofi86 commented Nov 5, 2019

Now I get it. it works in issues but not in DMS tab. sorry.

I added #74 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants