Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow with version change happen outside fastlane #50

Open
pke opened this issue Oct 5, 2020 · 1 comment
Open

Workflow with version change happen outside fastlane #50

pke opened this issue Oct 5, 2020 · 1 comment

Comments

@pke
Copy link

pke commented Oct 5, 2020

Thanks for the plugin. It will help to create nice changelogs for us.

Our versioning flow is a bit different though. We use release branches that first increment the package.json (and add a tag) and then call fastlane.
And since a fastlane deploy could fail for a number of reasons it would be bad to have a stamped changelog before the deploy succeeded.

Do you have any recommendation to handle such flow? One solution I could think of would be a git amend at the end of a successful deploy, which adds the stamped changelog or revert the last commit that tagged the version.

@pajapro
Copy link
Owner

pajapro commented Dec 20, 2020

Hi @pke

One solution I could think of would be a git amend at the end of a successful deploy, which adds the stamped changelog or revert the last commit that tagged the version.

Without knowledge about your CI I see 2 approaches:

1. approach

As you say, I would either git amend the stamped changelog or new git commit. In case your deployment would fail you can revert the last commit

2. approach

stamp the changelong (don't commit anything yet), start the deployment and in case it's successful git commit the stamped changelog or git reset working copy (changes caused by stamp in changelog).

Let me know whether it helped you resolve your question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants