Converts the diff actions to use files to avoid hit bash command length limit #1000
+188
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdimsdale
reviewed
Dec 13, 2024
robdimsdale
approved these changes
Dec 13, 2024
| @@ -277,8 +283,8 @@ jobs: | |||
| echo "packages_removed=false" >> "$GITHUB_OUTPUT" | |||
| fi | |||
| env: | |||
| BUILD_REMOVED: ${{ steps.build_diff.outputs.removed }} | |||
| RUN_REMOVED: ${{ steps.run_diff.outputs.removed }} | |||
| BUILD_REMOVED: "/github/workspace/${{ env.BUILD_DIFF_REMOVED_FILENAME }}" | |||
There was a problem hiding this comment.
Could we just inline this? I don't see the value in having these as environment variables anymore. It'll reduce complexity and save a few lines of yaml
There was a problem hiding this comment.
I am not confident that the env.BUILD_DIFF_REMOVED_FILENAME will work properly in the inline bash script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a job that is failing because there are too many modified packages. https://github.com/paketo-buildpacks/jammy-full-stack/actions/runs/12245473074/job/34159624482
Checklist