Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack: Validating generated build artifacts option on tests #994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Nov 12, 2024

Summary

This PR extends the functionality of test.sh script on stacks, to validate the generated artifacts before testing.
More specifically, if the option --validate-stack-builds is specified and the build artifacts are not generated or are not generated properly, then the script will throw an error.
The default behavior has not been changed, so in case the option --validate-stack-builds option is not specified, and some builds are missing, it will regenerate them.

Also, on this PR, it has been changed on where to look for the images.json file, as the default location has changed.

Use Cases

The --validate-stack-builds option is useful on the create release workflow, where we want to ensure that the generated artifacts that are generated from previous steps, are not missing. So, in case of missing artifacts, the script will not regenerate them, instead, it will throw an error.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner November 12, 2024 14:18
@pacostas pacostas changed the title Stack: Validating generate artifacts option on tests Stack: Validating generated build artifacts option on tests Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant