-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds create-stack command #53
Conversation
d7fa313
to
b7922f9
Compare
@ryanmoran I plan on giving this a full review tomorrow, just as an update! |
I have a small suggestion I want to hear your opinion on. I think that it might be nice to have a default vanilla stack descriptor file available with the command, or some kind of separate command that will give users a template. I understand that within the project we will largely be using this with our own stack descriptor files, but for the sake of ease of use for users that might want to leverage this tool themselves we should make it as easy as possible. |
Also, unrelated and probably not a big deal but I observed the packing process taking substantially longer now:
This is versus the |
9c6dabd
to
dcefab4
Compare
I'm not seeing this same slowdown. Can you confirm that this happens consistently with rebuilds? Is this from a fresh clone of the repo? |
This sounds reasonable, but maybe requires a separate issue and PR? |
0770f00
to
579ecba
Compare
It was a fresh clone of the repository, yes. But you're right subsequent builds are 11 seconds (when the |
@ryanmoran issue filed for my suggestion: #56 |
@ryanmoran Appreciate the documentation additions. Can you fix the merge conflicts? Then we can get this merged in! |
- moves top-level tests into integration directory
Summary
Resolves #52
Also, moves top-level tests into
integration
directory.Checklist