From fca89b336c6c3d724738fc1ae43a3032f2839cc2 Mon Sep 17 00:00:00 2001 From: Carter Kozak Date: Sun, 3 Mar 2024 13:22:29 -0500 Subject: [PATCH 1/2] Enable DNS node discovery by default --- .../palantir/dialogue/clients/ReloadingClientFactory.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/dialogue-clients/src/main/java/com/palantir/dialogue/clients/ReloadingClientFactory.java b/dialogue-clients/src/main/java/com/palantir/dialogue/clients/ReloadingClientFactory.java index 22ad614c4..9a02b0187 100644 --- a/dialogue-clients/src/main/java/com/palantir/dialogue/clients/ReloadingClientFactory.java +++ b/dialogue-clients/src/main/java/com/palantir/dialogue/clients/ReloadingClientFactory.java @@ -127,12 +127,6 @@ public Channel getNonReloadingChannel(String channelName, ClientConfiguration in params.runtime().clients()); } - // allow enabling dns node discovery by setting an environment variable - // note that this can still be disabled explicitly via the factory, but having a global flag - // that overrides the default value allows for enabling this behavior without explicit code - // changes - private static final String ENABLE_DNS_NODE_DISCOVERY_ENV_VAR = "DIALOGUE_ENABLE_EXPERIMENTAL_DNS_NODE_DISCOVERY"; - @Value.Immutable interface ReloadingParams extends AugmentClientConfig { @@ -172,7 +166,7 @@ default Duration dnsRefreshInterval() { @Value.Default default boolean dnsNodeDiscovery() { - return "true".equalsIgnoreCase(System.getenv(ENABLE_DNS_NODE_DISCOVERY_ENV_VAR)); + return true; } Optional blockingExecutor(); From 1ab117d2bf4899906a5a73de90e8780755f5bbea Mon Sep 17 00:00:00 2001 From: svc-changelog Date: Sun, 3 Mar 2024 18:25:09 +0000 Subject: [PATCH 2/2] Add generated changelog entries --- changelog/@unreleased/pr-2182.v2.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/@unreleased/pr-2182.v2.yml diff --git a/changelog/@unreleased/pr-2182.v2.yml b/changelog/@unreleased/pr-2182.v2.yml new file mode 100644 index 000000000..79b54554d --- /dev/null +++ b/changelog/@unreleased/pr-2182.v2.yml @@ -0,0 +1,5 @@ +type: feature +feature: + description: Enable DNS node discovery by default + links: + - https://github.com/palantir/dialogue/pull/2182