From 7618c945830b1dd367bf728017ed0ca99a44f8e5 Mon Sep 17 00:00:00 2001 From: Robert Fink Date: Thu, 23 Feb 2017 17:24:30 -0800 Subject: [PATCH 1/2] Remove baseline-findbugs --- .../resources/findbugs/excludeFilter.xml | 25 ----- .../palantir/baseline/plugins/Baseline.groovy | 1 - .../baseline/plugins/BaselineEclipse.groovy | 2 +- .../baseline/plugins/BaselineFindBugs.groovy | 96 ------------------- .../com.palantir.baseline-findbugs.properties | 1 - .../BaselineConfigIntegrationTest.groovy | 2 +- .../baseline/BaselineFindBugsTest.groovy | 39 -------- .../com/palantir/baseline/BaselineTest.groovy | 7 +- 8 files changed, 3 insertions(+), 170 deletions(-) delete mode 100644 gradle-baseline-java-config/resources/findbugs/excludeFilter.xml delete mode 100644 gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy delete mode 100644 gradle-baseline-java/src/main/resources/META-INF/gradle-plugins/com.palantir.baseline-findbugs.properties delete mode 100644 gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFindBugsTest.groovy diff --git a/gradle-baseline-java-config/resources/findbugs/excludeFilter.xml b/gradle-baseline-java-config/resources/findbugs/excludeFilter.xml deleted file mode 100644 index ebebbf127..000000000 --- a/gradle-baseline-java-config/resources/findbugs/excludeFilter.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/Baseline.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/Baseline.groovy index a22adee7a..767b5f0a6 100644 --- a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/Baseline.groovy +++ b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/Baseline.groovy @@ -27,7 +27,6 @@ class Baseline implements Plugin { void apply(Project project) { project.plugins.apply BaselineCheckstyle project.plugins.apply BaselineConfig - project.plugins.apply BaselineFindBugs project.plugins.apply BaselineEclipse project.plugins.apply BaselineIdea } diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineEclipse.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineEclipse.groovy index cddc41ee1..91542dc2a 100644 --- a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineEclipse.groovy +++ b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineEclipse.groovy @@ -101,7 +101,7 @@ class BaselineEclipse extends AbstractBaselinePlugin { } }) - // Configure Findbugs/Checkstyle/JdtUI settings by copying in the default Baseline config file. + // Configure Checkstyle/JdtUI settings by copying in the default Baseline config file. // Warning: this may interfere with other Gradle plugins that may try to mutate these files. project.afterEvaluate { Project p -> def eclipseTemplate = project.task( diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy deleted file mode 100644 index f1733f700..000000000 --- a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy +++ /dev/null @@ -1,96 +0,0 @@ -/* - * Copyright 2015 Palantir Technologies, Inc. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.palantir.baseline.plugins - -import org.gradle.api.Project -import org.gradle.api.plugins.quality.FindBugs -import org.gradle.api.plugins.quality.FindBugsPlugin -import org.gradle.plugins.ide.eclipse.EclipsePlugin - -import java.nio.file.Paths - -/** - * Configures the Gradle 'findbugs' task with Baseline-specific configuration. - */ -class BaselineFindBugs extends AbstractBaselinePlugin { - - private static final String DEFAULT_FINDBUGS_VERSION = '3.0.1' - private static final String DEFAULT_EFFORT = 'max' - private static final String ANTIPATTERNS_ARTIFACT = 'com.palantir.antipatterns:antipatterns:1.0-beta.4' - // See https://github.com/KengoTODA/findbugs-slf4j/issues/48 for why this is not a transitive dependency - private static final String SLF4J_FINDBUGS_PLUGIN = 'jp.skypencil.findbugs.slf4j:bug-pattern:1.2.4@jar' - private static final String[] OMITTED_VISITORS = ["StaticLoggerDetector"] - - void apply(Project project) { - this.project = project - - project.plugins.apply FindBugsPlugin - - // Set report type. - // We do this at 'apply' time so that they could be overridden by a user later. - // 'html' is human-readable; 'xml' can be read by the Eclipse FindBugs plugin. - // Only one can be enabled at a time. - // Note: This only affects FindBugs tasks that exist when this plugin is applied. - project.tasks.withType(FindBugs) { - reports { - xml.enabled = false - html.enabled = true - } - } - - // Configure not in afterEvaluate so that user can override. - configureFindBugs() - - project.afterEvaluate { Project p -> - configureFindBugsForEclipse() - } - } - - def configureFindBugs() { - project.logger.debug("Baseline: Configuring FindBugs tasks") - - // Configure findbugs - project.findbugs { - toolVersion = DEFAULT_FINDBUGS_VERSION - excludeFilter = excludeFilterFile - effort = DEFAULT_EFFORT - omitVisitors = OMITTED_VISITORS - } - - project.dependencies { - findbugsPlugins ANTIPATTERNS_ARTIFACT - findbugsPlugins SLF4J_FINDBUGS_PLUGIN - } - } - - // Configure checkstyle settings for Eclipse - def configureFindBugsForEclipse() { - if (!project.plugins.findPlugin(EclipsePlugin)) { - project.logger.debug "Baseline: Skipping configuring Eclipse for FindBugs (eclipse not applied)" - return - } - project.logger.debug "Baseline: Configuring Eclipse FindBugs" - project.eclipse.project { - natures "edu.umd.cs.findbugs.plugin.eclipse.findbugsNature" - buildCommand "edu.umd.cs.findbugs.plugin.eclipse.findbugsBuilder" - } - } - - File getExcludeFilterFile() { - project.file(Paths.get(configDir, "findbugs", "excludeFilter.xml").toString()) - } -} diff --git a/gradle-baseline-java/src/main/resources/META-INF/gradle-plugins/com.palantir.baseline-findbugs.properties b/gradle-baseline-java/src/main/resources/META-INF/gradle-plugins/com.palantir.baseline-findbugs.properties deleted file mode 100644 index 3a6378a4f..000000000 --- a/gradle-baseline-java/src/main/resources/META-INF/gradle-plugins/com.palantir.baseline-findbugs.properties +++ /dev/null @@ -1 +0,0 @@ -implementation-class=com.palantir.baseline.plugins.BaselineFindBugs diff --git a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineConfigIntegrationTest.groovy b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineConfigIntegrationTest.groovy index ef959767c..aea934b16 100644 --- a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineConfigIntegrationTest.groovy +++ b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineConfigIntegrationTest.groovy @@ -41,7 +41,7 @@ class BaselineConfigIntegrationTest extends AbstractPluginTest { then: with('baselineUpdateConfig').build() - directory('.baseline').list().toList() == ['checkstyle', 'copyright', 'eclipse', 'findbugs', 'idea'] + directory('.baseline').list().toList() == ['checkstyle', 'copyright', 'eclipse', 'idea'] } def 'Fails if no configuration dependency is specified'() { diff --git a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFindBugsTest.groovy b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFindBugsTest.groovy deleted file mode 100644 index 5f033441b..000000000 --- a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFindBugsTest.groovy +++ /dev/null @@ -1,39 +0,0 @@ -/* - * Copyright 2015 Palantir Technologies, Inc. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.palantir.baseline - -import com.palantir.baseline.plugins.BaselineFindBugs -import org.gradle.api.Project -import org.gradle.api.plugins.quality.FindBugsPlugin -import org.gradle.testfixtures.ProjectBuilder -import spock.lang.Specification - -class BaselineFindBugsTest extends Specification { - private Project project - - def setup() { - project = ProjectBuilder.builder().build() - project.plugins.apply 'java' - project.plugins.apply BaselineFindBugs - } - - def testPluginsAreApplied() { - expect: - project.plugins.hasPlugin(BaselineFindBugs.class) - project.plugins.hasPlugin(FindBugsPlugin.class) - } -} diff --git a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineTest.groovy b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineTest.groovy index d307ce353..963842b5b 100644 --- a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineTest.groovy +++ b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineTest.groovy @@ -18,7 +18,7 @@ package com.palantir.baseline import com.palantir.baseline.plugins.BaselineCheckstyle import com.palantir.baseline.plugins.BaselineEclipse -import com.palantir.baseline.plugins.BaselineFindBugs + import com.palantir.baseline.plugins.Baseline import static org.junit.Assert.assertTrue @@ -49,11 +49,6 @@ class BaselineTest { assertTrue project.plugins.hasPlugin(Baseline.class) } - @Test - public void baselineFindBugsProjectApplied() { - assertTrue project.plugins.hasPlugin(BaselineFindBugs.class) - } - @Test public void baselineCheckstyleProjectApplied() { assertTrue project.plugins.hasPlugin(BaselineCheckstyle.class) From b677ea5fbee94321befccdb32a307823f3c02f95 Mon Sep 17 00:00:00 2001 From: Robert Fink Date: Tue, 7 Mar 2017 13:01:51 -0500 Subject: [PATCH 2/2] Remove more --- README.md | 39 +--- .../java-coding-guidelines/readme.md | 2 +- .../edu.umd.cs.findbugs.core.prefs | 171 ------------------ .../edu.umd.cs.findbugs.plugin.eclipse.prefs | 5 - gradle-baseline-java/build.gradle | 6 +- 5 files changed, 9 insertions(+), 214 deletions(-) delete mode 100644 gradle-baseline-java-config/resources/eclipse/dynamic/dotfile.settings/edu.umd.cs.findbugs.core.prefs delete mode 100644 gradle-baseline-java-config/resources/eclipse/static/dotfile.settings/edu.umd.cs.findbugs.plugin.eclipse.prefs diff --git a/README.md b/README.md index 66e281db2..4d34e302b 100644 --- a/README.md +++ b/README.md @@ -5,8 +5,7 @@ Baseline Java is a collection of Gradle plugins for configuring code quality tools in builds and generated Eclipse/IntelliJ projects. It configures [Checkstyle](http://checkstyle.sourceforge.net) for style and formatting -checks, [FindBugs](http://findbugs.sourceforge.net/) for catching common bugs, and Eclipse/IntelliJ code style and -formatting configurations. +checks, and Eclipse/IntelliJ code style and formatting configurations. The Baseline plugins are compatible with Gradle 2.2.1 and above. @@ -47,18 +46,17 @@ apply plugin: 'com.palantir.baseline-config' // Apply plugins selectively depending on required functionality. apply plugin: 'com.palantir.baseline-checkstyle' apply plugin: 'com.palantir.baseline-eclipse' -apply plugin: 'com.palantir.baseline-findbugs' apply plugin: 'com.palantir.baseline-idea' ``` - Run ``./gradlew baselineUpdateConfig`` to download the config files referenced in the `dependencies.baseline` configuration and extract them to .baseline/ -- Any subsequent ``./gradlew build`` invokes Checkstyle and FindBugs as part of the build and test tasks (if the +- Any subsequent ``./gradlew build`` invokes Checkstyle as part of the build and test tasks (if the respective baseline-xyz plugins are applied). - The ``eclipse`` and ``idea`` Gradle tasks generate projects pre-configured with Baseline settings: - Code style and code formatting rules conforming with Baseline style - - Checkstyle and FindBugs configuration + - Checkstyle configuration Note that the Checkstyle-IDEA plugin is required to run the Baseline Checkstyle within IntelliJ. @@ -68,7 +66,7 @@ respective baseline-xyz plugins are applied). ## Plugin Architecture Overview The Baseline plugins `com.palantir.baseline-checkstyle`, `com.palantir.baseline-eclipse`, -`com.palantir.baseline-findbugs`, `com.palantir.baseline-idea` apply the configuration present in `.baseline` to the +`com.palantir.baseline-idea` apply the configuration present in `.baseline` to the respective Gradle tasks. For example, any Gradle Checkstyle tasks uses the Checkstyle configuration in `.baseline/checkstyle/checkstyle.xml`, and any IntelliJ/Eclipse project generated by `./gradlew eclipse idea` is configured with Baseline code formatting and Checkstyle rules. Note that each of these plugins automatically applies the @@ -81,7 +79,7 @@ applies `eclipse`, etc. ## Configuration -The standard Gradle configuration options for the underlying plugins (Eclipse, IntelliJ, Checkstyle, FindBugs) can be +The standard Gradle configuration options for the underlying plugins (Eclipse, IntelliJ, Checkstyle) can be used, with the following exception: - `checkstyle.configFile` - not compatible with Baseline since the file location is hard-coded to @@ -169,10 +167,9 @@ The `com.palantir.baseline-eclipse` plugin automatically applies the `eclipse` p If set, `sourceCompatibility` is used to configure the Eclipse project settings and the Eclipse JDK version. Note that `targetCompatibility` is also honored and defaults to `sourceCompatibility`. -Generated Eclipse projects have default per-project code formatting rules as well as Checkstyle and FindBugs -configuration. +Generated Eclipse projects have default per-project code formatting rules as well as Checkstyle configuration. -The Eclipse plugin is compatible with the following versions: Checkstyle 6.5+, FindBugs 3.0.0+, JDK 1.7, 1.8 +The Eclipse plugin is compatible with the following versions: Checkstyle 7.5+, JDK 1.7, 1.8 ### IntelliJ Plugin (com.palantir.baseline-idea) @@ -186,28 +183,6 @@ Generated IntelliJ projects have default per-project code formatting rules as we and Java language level settings are picked up from the Gradle `sourceCompatibility` property on a per-module basis. -### FindBugs Plugin (com.palantir.baseline-findbugs) - -Checks can be suppressed by annotating the class/method/field in question with: - -```Java -@SuppressFBWarning("BUG_PATTERN_NAME") -``` - -The BUG_PATTERN_NAME can be derived from the "Pattern" field in the Eclipse Bug Info View. - -More complicated filters can be handled via the `.baseline/findbugs/excludeFilter.xml` file; see [FindBugs -documentation](http://findbugs.sourceforge.net/manual/filter.html) for details. - -We apply the [antipatterns](https://github.com/palantir/antipatterns) Gradle plugin; if you wish to change -the version of this plugin, please do so by adding - - dependencies { - findbugsPlugins "com.palantir.antipatterns:$antipatternsVersion" - } - -to your project dependencies. - ### Copyright Checks By default Baseline enforces Palantir copyright at the beginning of files. To change this, edit the template copyright diff --git a/docs/best-practices/java-coding-guidelines/readme.md b/docs/best-practices/java-coding-guidelines/readme.md index 22940ce71..af316eca0 100644 --- a/docs/best-practices/java-coding-guidelines/readme.md +++ b/docs/best-practices/java-coding-guidelines/readme.md @@ -1502,7 +1502,7 @@ See *Effective Java, 2nd Edition, Items 68-69* Concurrency bugs are very difficult to reliably fix, as their manifestations are very transient. By writing very simple synchronization schemes, code inspection is much more effective to -detect and fix these issues. (Tools like FindBugs will also perform +detect and fix these issues. (Tools like Google's error-prone will also perform better at detecting issues.) Often times it is best to simply avoid explicit synchronization in the diff --git a/gradle-baseline-java-config/resources/eclipse/dynamic/dotfile.settings/edu.umd.cs.findbugs.core.prefs b/gradle-baseline-java-config/resources/eclipse/dynamic/dotfile.settings/edu.umd.cs.findbugs.core.prefs deleted file mode 100644 index 353d91daf..000000000 --- a/gradle-baseline-java-config/resources/eclipse/dynamic/dotfile.settings/edu.umd.cs.findbugs.core.prefs +++ /dev/null @@ -1,171 +0,0 @@ -#FindBugs User Preferences -#Sun Mar 02 18:15:35 EST 2014 -cloud_id=edu.umd.cs.findbugs.cloud.doNothingCloud -detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true -detectorAtomicityProblem=AtomicityProblem|true -detectorBadAppletConstructor=BadAppletConstructor|false -detectorBadResultSetAccess=BadResultSetAccess|true -detectorBadSyntaxForRegularExpression=BadSyntaxForRegularExpression|true -detectorBadUseOfReturnValue=BadUseOfReturnValue|true -detectorBadlyOverriddenAdapter=BadlyOverriddenAdapter|true -detectorBooleanReturnNull=BooleanReturnNull|true -detectorBuildInterproceduralCallGraph=BuildInterproceduralCallGraph|false -detectorBuildObligationPolicyDatabase=BuildObligationPolicyDatabase|true -detectorCallToUnsupportedMethod=CallToUnsupportedMethod|false -detectorCalledMethods=CalledMethods|true -detectorCheckCalls=CheckCalls|false -detectorCheckExpectedWarnings=CheckExpectedWarnings|false -detectorCheckImmutableAnnotation=CheckImmutableAnnotation|true -detectorCheckRelaxingNullnessAnnotation=CheckRelaxingNullnessAnnotation|true -detectorCheckTypeQualifiers=CheckTypeQualifiers|true -detectorCloneIdiom=CloneIdiom|true -detectorComparatorIdiom=ComparatorIdiom|true -detectorConfusedInheritance=ConfusedInheritance|true -detectorConfusionBetweenInheritedAndOuterMethod=ConfusionBetweenInheritedAndOuterMethod|true -detectorCovariantArrayAssignment=CovariantArrayAssignment|false -detectorCrossSiteScripting=CrossSiteScripting|true -detectorDefaultEncodingDetector=DefaultEncodingDetector|true -detectorDoInsideDoPrivileged=DoInsideDoPrivileged|true -detectorDontCatchIllegalMonitorStateException=DontCatchIllegalMonitorStateException|true -detectorDontIgnoreResultOfPutIfAbsent=DontIgnoreResultOfPutIfAbsent|true -detectorDontUseEnum=DontUseEnum|true -detectorDroppedException=DroppedException|true -detectorDumbMethodInvocations=DumbMethodInvocations|true -detectorDumbMethods=DumbMethods|true -detectorDuplicateBranches=DuplicateBranches|true -detectorEmptyZipFileEntry=EmptyZipFileEntry|true -detectorEqualsOperandShouldHaveClassCompatibleWithThis=EqualsOperandShouldHaveClassCompatibleWithThis|true -detectorExplicitSerialization=ExplicitSerialization|true -detectorFieldItemSummary=FieldItemSummary|true -detectorFinalizerNullsFields=FinalizerNullsFields|true -detectorFindBadCast2=FindBadCast2|true -detectorFindBadForLoop=FindBadForLoop|true -detectorFindBugsSummaryStats=FindBugsSummaryStats|true -detectorFindCircularDependencies=FindCircularDependencies|false -detectorFindComparatorProblems=FindComparatorProblems|true -detectorFindDeadLocalStores=FindDeadLocalStores|true -detectorFindDoubleCheck=FindDoubleCheck|true -detectorFindEmptySynchronizedBlock=FindEmptySynchronizedBlock|true -detectorFindFieldSelfAssignment=FindFieldSelfAssignment|true -detectorFindFinalizeInvocations=FindFinalizeInvocations|true -detectorFindFloatEquality=FindFloatEquality|true -detectorFindHEmismatch=FindHEmismatch|true -detectorFindInconsistentSync2=FindInconsistentSync2|true -detectorFindJSR166LockMonitorenter=FindJSR166LockMonitorenter|true -detectorFindLocalSelfAssignment2=FindLocalSelfAssignment2|true -detectorFindMaskedFields=FindMaskedFields|true -detectorFindMismatchedWaitOrNotify=FindMismatchedWaitOrNotify|true -detectorFindNakedNotify=FindNakedNotify|true -detectorFindNonShortCircuit=FindNonShortCircuit|true -detectorFindNullDeref=FindNullDeref|true -detectorFindNullDerefsInvolvingNonShortCircuitEvaluation=FindNullDerefsInvolvingNonShortCircuitEvaluation|true -detectorFindOpenStream=FindOpenStream|true -detectorFindPuzzlers=FindPuzzlers|true -detectorFindRefComparison=FindRefComparison|true -detectorFindReturnRef=FindReturnRef|true -detectorFindRoughConstants=FindRoughConstants|true -detectorFindRunInvocations=FindRunInvocations|true -detectorFindSelfComparison=FindSelfComparison|true -detectorFindSelfComparison2=FindSelfComparison2|true -detectorFindSleepWithLockHeld=FindSleepWithLockHeld|true -detectorFindSpinLoop=FindSpinLoop|true -detectorFindSqlInjection=FindSqlInjection|true -detectorFindTwoLockWait=FindTwoLockWait|true -detectorFindUncalledPrivateMethods=FindUncalledPrivateMethods|true -detectorFindUnconditionalWait=FindUnconditionalWait|true -detectorFindUninitializedGet=FindUninitializedGet|true -detectorFindUnrelatedTypesInGenericContainer=FindUnrelatedTypesInGenericContainer|true -detectorFindUnreleasedLock=FindUnreleasedLock|true -detectorFindUnsatisfiedObligation=FindUnsatisfiedObligation|true -detectorFindUnsyncGet=FindUnsyncGet|true -detectorFindUseOfNonSerializableValue=FindUseOfNonSerializableValue|true -detectorFindUselessControlFlow=FindUselessControlFlow|true -detectorFindUselessObjects=FindUselessObjects|true -detectorFormatStringChecker=FormatStringChecker|true -detectorFunctionsThatMightBeMistakenForProcedures=FunctionsThatMightBeMistakenForProcedures|true -detectorHugeSharedStringConstants=HugeSharedStringConstants|true -detectorIDivResultCastToDouble=IDivResultCastToDouble|true -detectorIncompatMask=IncompatMask|true -detectorInconsistentAnnotations=InconsistentAnnotations|true -detectorInefficientMemberAccess=InefficientMemberAccess|false -detectorInefficientToArray=InefficientToArray|true -detectorInfiniteLoop=InfiniteLoop|true -detectorInfiniteRecursiveLoop=InfiniteRecursiveLoop|true -detectorInheritanceUnsafeGetResource=InheritanceUnsafeGetResource|true -detectorInitializationChain=InitializationChain|true -detectorInitializeNonnullFieldsInConstructor=InitializeNonnullFieldsInConstructor|true -detectorInstantiateStaticClass=InstantiateStaticClass|true -detectorIntCast2LongAsInstant=IntCast2LongAsInstant|true -detectorInvalidJUnitTest=InvalidJUnitTest|true -detectorIteratorIdioms=IteratorIdioms|true -detectorLazyInit=LazyInit|true -detectorLoadOfKnownNullValue=LoadOfKnownNullValue|true -detectorLostLoggerDueToWeakReference=LostLoggerDueToWeakReference|true -detectorMethodReturnCheck=MethodReturnCheck|true -detectorMethods=Methods|true -detectorMultithreadedInstanceAccess=MultithreadedInstanceAccess|true -detectorMutableEnum=MutableEnum|true -detectorMutableLock=MutableLock|true -detectorMutableStaticFields=MutableStaticFields|true -detectorNaming=Naming|true -detectorNoise=Noise|false -detectorNoiseNullDeref=NoiseNullDeref|false -detectorNoteAnnotationRetention=NoteAnnotationRetention|true -detectorNoteCheckReturnValueAnnotations=NoteCheckReturnValueAnnotations|true -detectorNoteDirectlyRelevantTypeQualifiers=NoteDirectlyRelevantTypeQualifiers|true -detectorNoteJCIPAnnotation=NoteJCIPAnnotation|true -detectorNoteNonNullAnnotations=NoteNonNullAnnotations|true -detectorNoteNonnullReturnValues=NoteNonnullReturnValues|true -detectorNoteSuppressedWarnings=NoteSuppressedWarnings|true -detectorNoteUnconditionalParamDerefs=NoteUnconditionalParamDerefs|true -detectorNumberConstructor=NumberConstructor|true -detectorOptionalReturnNull=OptionalReturnNull|true -detectorOverridingEqualsNotSymmetrical=OverridingEqualsNotSymmetrical|true -detectorPreferZeroLengthArrays=PreferZeroLengthArrays|true -detectorPublicSemaphores=PublicSemaphores|false -detectorQuestionableBooleanAssignment=QuestionableBooleanAssignment|true -detectorReadOfInstanceFieldInMethodInvokedByConstructorInSuperclass=ReadOfInstanceFieldInMethodInvokedByConstructorInSuperclass|true -detectorReadReturnShouldBeChecked=ReadReturnShouldBeChecked|true -detectorRedundantConditions=RedundantConditions|true -detectorRedundantInterfaces=RedundantInterfaces|true -detectorReflectiveClasses=ReflectiveClasses|true -detectorRepeatedConditionals=RepeatedConditionals|true -detectorResolveAllReferences=ResolveAllReferences|false -detectorRuntimeExceptionCapture=RuntimeExceptionCapture|true -detectorSerializableIdiom=SerializableIdiom|true -detectorStartInConstructor=StartInConstructor|true -detectorStaticCalendarDetector=StaticCalendarDetector|true -detectorStringConcatenation=StringConcatenation|true -detectorSuperfluousInstanceOf=SuperfluousInstanceOf|true -detectorSuspiciousThreadInterrupted=SuspiciousThreadInterrupted|true -detectorSwitchFallthrough=SwitchFallthrough|true -detectorSynchronizationOnSharedBuiltinConstant=SynchronizationOnSharedBuiltinConstant|true -detectorSynchronizeAndNullCheckField=SynchronizeAndNullCheckField|true -detectorSynchronizeOnClassLiteralNotGetClass=SynchronizeOnClassLiteralNotGetClass|true -detectorSynchronizingOnContentsOfFieldToProtectField=SynchronizingOnContentsOfFieldToProtectField|true -detectorTestASM=TestASM|false -detectorTestDataflowAnalysis=TestDataflowAnalysis|false -detectorTestingGround=TestingGround|false -detectorTestingGround2=TestingGround2|false -detectorTrainFieldStoreTypes=TrainFieldStoreTypes|true -detectorTrainLongInstantfParams=TrainLongInstantfParams|true -detectorTrainNonNullAnnotations=TrainNonNullAnnotations|true -detectorTrainUnconditionalDerefParams=TrainUnconditionalDerefParams|true -detectorURLProblems=URLProblems|true -detectorUncallableMethodOfAnonymousClass=UncallableMethodOfAnonymousClass|true -detectorUnnecessaryMath=UnnecessaryMath|true -detectorUnreadFields=UnreadFields|true -detectorUselessSubclassMethod=UselessSubclassMethod|true -detectorVarArgsProblems=VarArgsProblems|true -detectorVolatileUsage=VolatileUsage|true -detectorWaitInLoop=WaitInLoop|true -detectorWrongMapIterator=WrongMapIterator|true -detectorXMLFactoryBypass=XMLFactoryBypass|true -detector_threshold=2 -effort=max -excludefilter0=${configDir}/findbugs/excludeFilter.xml|true -filter_settings=Medium|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false|20 -filter_settings_neg=NOISE| -plugin0=edu.umd.cs.findbugs.plugins.findbugsCommunalCloud|false -plugin1=edu.umd.cs.findbugs.plugins.webCloud|false -run_at_full_build=true diff --git a/gradle-baseline-java-config/resources/eclipse/static/dotfile.settings/edu.umd.cs.findbugs.plugin.eclipse.prefs b/gradle-baseline-java-config/resources/eclipse/static/dotfile.settings/edu.umd.cs.findbugs.plugin.eclipse.prefs deleted file mode 100644 index c513986b8..000000000 --- a/gradle-baseline-java-config/resources/eclipse/static/dotfile.settings/edu.umd.cs.findbugs.plugin.eclipse.prefs +++ /dev/null @@ -1,5 +0,0 @@ -eclipse.preferences.version=1 -edu.umd.cs.findbugs.plugin.eclipse.findbugsMarkerOfConcern=Warning -edu.umd.cs.findbugs.plugin.eclipse.findbugsMarkerScariest=Error -edu.umd.cs.findbugs.plugin.eclipse.findbugsMarkerScary=Warning -edu.umd.cs.findbugs.plugin.eclipse.findbugsMarkerTroubling=Warning diff --git a/gradle-baseline-java/build.gradle b/gradle-baseline-java/build.gradle index c2646ca1d..e3f6d6e18 100644 --- a/gradle-baseline-java/build.gradle +++ b/gradle-baseline-java/build.gradle @@ -66,7 +66,7 @@ pluginBundle { website = 'https://github.com/palantir/gradle-baseline' vcsUrl = 'https://github.com/palantir/gradle-baseline' description = 'Baseline Java is a collection of Gradle plugins for configuring code quality tools in builds and generated Eclipse/IntelliJ projects.' - tags = ['java', 'checkstyle', 'code quality', 'findbugs', 'eclipse', 'idea'] + tags = ['java', 'checkstyle', 'code quality', 'eclipse', 'idea'] plugins { baselinePlugins { @@ -85,10 +85,6 @@ pluginBundle { id = 'com.palantir.baseline-eclipse' displayName = 'Palantir Baseline Eclipse Plugin' } - baselineFindbugsPlugin { - id = 'com.palantir.baseline-findbugs' - displayName = 'Palantir Baseline FindBugs Plugin' - } baselineIdeaPlugin { id = 'com.palantir.baseline-idea' displayName = 'Palantir Baseline IntelliJ Plugin'