diff --git a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java index e61cc235a..3e29f4266 100644 --- a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java +++ b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java @@ -39,7 +39,7 @@ name = "PreferSafeLoggableExceptions", link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", linkType = BugPattern.LinkType.CUSTOM, - severity = BugPattern.SeverityLevel.SUGGESTION, + severity = BugPattern.SeverityLevel.WARNING, summary = "Throw SafeLoggable exceptions to ensure the exception message will not be redacted") public final class PreferSafeLoggableExceptions extends BugChecker implements BugChecker.NewClassTreeMatcher { diff --git a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java index 334799640..10e4233a4 100644 --- a/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java +++ b/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java @@ -40,7 +40,7 @@ name = "PreferSafeLoggingPreconditions", link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", linkType = BugPattern.LinkType.CUSTOM, - severity = BugPattern.SeverityLevel.SUGGESTION, + severity = BugPattern.SeverityLevel.WARNING, summary = "Precondition and similar checks with a constant message and no parameters should use equivalent " + "checks from com.palantir.logsafe.Preconditions for standardization as functionality is the same.") public final class PreferSafeLoggingPreconditions extends BugChecker implements BugChecker.MethodInvocationTreeMatcher { diff --git a/changelog/@unreleased/pr-697.v2.yml b/changelog/@unreleased/pr-697.v2.yml new file mode 100644 index 000000000..348438077 --- /dev/null +++ b/changelog/@unreleased/pr-697.v2.yml @@ -0,0 +1,5 @@ +type: improvement +improvement: + description: The severity of PreferSafeLoggableExceptions and PreferSafeLoggingPreconditions is now WARNING. + links: + - https://github.com/palantir/gradle-baseline/pull/704