From 8179e41e56eedc46ba7970cdec1a7ec961428e69 Mon Sep 17 00:00:00 2001 From: Carter Kozak Date: Fri, 16 Aug 2019 22:11:38 -0400 Subject: [PATCH 1/2] Revert "Include more checks to be patched (#751)" This reverts commit 3a2f3508b3c8572b3188b834e3297aeaf32fba98. --- .../baseline/extensions/BaselineErrorProneExtension.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java index 7ac038e4a..5254c496e 100644 --- a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java +++ b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java @@ -33,9 +33,7 @@ public class BaselineErrorProneExtension { // Built-in checks "ArrayEquals", - "MissingOverride", - "UnusedMethod", - "UnusedVariable"); + "MissingOverride"); private final ListProperty patchChecks; From 91f996028cf50b3547bf1e364a3de5a1ab3a0c2e Mon Sep 17 00:00:00 2001 From: Carter Kozak Date: Fri, 16 Aug 2019 22:14:00 -0400 Subject: [PATCH 2/2] changelog --- changelog/@unreleased/revert-pr-751.v2.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/@unreleased/revert-pr-751.v2.yml diff --git a/changelog/@unreleased/revert-pr-751.v2.yml b/changelog/@unreleased/revert-pr-751.v2.yml new file mode 100644 index 000000000..f8f3f1426 --- /dev/null +++ b/changelog/@unreleased/revert-pr-751.v2.yml @@ -0,0 +1,5 @@ +type: fix +fix: + description: Do not apply the suggested fixes for `UnusedMethod` and `UnusedVariable` which automaticall remove code with side effects. + links: + - https://github.com/palantir/gradle-baseline/pull/757