Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement completionItem/resolve #905

Closed

Conversation

krassowski
Copy link

Fixes #903

  • implemented new hook for resolve
  • implemented resolve in jedi_completion and rope_completion
  • added eager option to rope_completion and jedi_completion allow users using clients which cannot yet handle completionItem/resolve to restore to eager resolution (inside of textDocument/completions)
  • added test for resolve and documentation in Jedi
  • tested with development version of JupyterLab-LSP client; the client implementation was tested against reference JavaScript/TypeScript server and against the R-languageserver

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @krassowski! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@krassowski krassowski force-pushed the feature/completionItem/resolve branch 2 times, most recently from 2226735 to d6089a3 Compare January 30, 2021 16:08
@krassowski krassowski force-pushed the feature/completionItem/resolve branch from d6089a3 to bec3068 Compare January 30, 2021 16:20
@krassowski
Copy link
Author

@ccordoba12 thanks for expressing your interest! The PR is now green and ready for review.

@krassowski
Copy link
Author

Cross-referencing my other implementation in pappasam/jedi-language-server#56 which is very similar but some details differ mostly and it might be helpful to compare those during review.

@krassowski
Copy link
Author

I believe that the CI failures after last commit are caused by a new release of a dependency used in tests (numpy?) and not by my code. It also explains why only the modern versions (Py3.7 and Py3.8) fail.

@krassowski krassowski force-pushed the feature/completionItem/resolve branch from 7f836cb to 318d0e2 Compare February 15, 2021 20:00
@andfoy
Copy link
Contributor

andfoy commented Feb 19, 2021

@krassowski, thanks for this PR, right now we lost our permissions on this repo, and we're waiting to see if it is going to be moved to a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement completionItem/resolve
3 participants