-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement completionItem/resolve #905
Implement completionItem/resolve #905
Conversation
Thanks for your interest in palantir/python-language-server, @krassowski! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
2226735
to
d6089a3
Compare
d6089a3
to
bec3068
Compare
@ccordoba12 thanks for expressing your interest! The PR is now green and ready for review. |
Cross-referencing my other implementation in pappasam/jedi-language-server#56 which is very similar but some details differ mostly and it might be helpful to compare those during review. |
I believe that the CI failures after last commit are caused by a new release of a dependency used in tests (numpy?) and not by my code. It also explains why only the modern versions (Py3.7 and Py3.8) fail. |
7f836cb
to
318d0e2
Compare
@krassowski, thanks for this PR, right now we lost our permissions on this repo, and we're waiting to see if it is going to be moved to a fork |
Fixes #903
eager
option to rope_completion and jedi_completion allow users using clients which cannot yet handlecompletionItem/resolve
to restore to eager resolution (inside oftextDocument/completions
)