-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solving issue #35 #41
Conversation
Thank you and sorry for taking so long to review! I think that to pass CMD check this will need:
Technically |
@paleolimbot I can clean this up and merge if you like. I have some time today or this week. |
That would be great! It sounds like it would solve problems for quite a few people! |
I suggest we do it via options(), so that users would be able to adjust it. I am pushing a PR in few minutes. Let's take these two issues separately (in two different PRs) |
@paleolimbot Can you add me as a collaborator again so I can merge this commit? |
Done! |
@paleolimbot Sorry, apparently my internet connection wasn't working when I accepted the invitation and it didn't go through. Could you resend the collaboration invite? I've got the bugs in this PR all fixed. |
@paleolimbot just bumping this |
Oh, I am sorry. I did not realize that the changes on my fork will be taking into account here. I just have been using the original code of @paleolimbot but introducing some features that works for me. Again, my apologizes, I will remove this thread. |
Solving issue #35 applying the solution #35 (comment)