Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issue #35 #41

Closed
wants to merge 7 commits into from
Closed

Solving issue #35 #41

wants to merge 7 commits into from

Conversation

LuisLauM
Copy link

Solving issue #35 applying the solution #35 (comment)

@paleolimbot
Copy link
Owner

Thank you and sorry for taking so long to review!

I think that to pass CMD check this will need:

  • Add #' @param include.chunks Use TRUE to include citations in code chunks to the documentation for bbt_detect_citations().
  • Running devtools::document() when this project is open in RStudio

Technically include_chunks would be more consistent with current argument names than include.chunks; however, I'm happy to have this feature added either way!

@bwiernik
Copy link
Contributor

@paleolimbot I can clean this up and merge if you like. I have some time today or this week.

@paleolimbot
Copy link
Owner

That would be great! It sounds like it would solve problems for quite a few people!

@dmi3kno
Copy link
Contributor

dmi3kno commented Jun 28, 2023

I suggest we do it via options(), so that users would be able to adjust it. I am pushing a PR in few minutes. Let's take these two issues separately (in two different PRs)

@bwiernik
Copy link
Contributor

@paleolimbot Can you add me as a collaborator again so I can merge this commit?

@paleolimbot
Copy link
Owner

Done!

@bwiernik
Copy link
Contributor

@paleolimbot Sorry, apparently my internet connection wasn't working when I accepted the invitation and it didn't go through. Could you resend the collaboration invite? I've got the bugs in this PR all fixed.

@dmi3kno
Copy link
Contributor

dmi3kno commented Aug 1, 2023

If you decide to merge this instead of #42 could you, please add more prefixes, other than just ^fig- and ^tbl-? I would ideally want a pair of eyes to look at my alternative implementation and critique it (#42).

@bwiernik
Copy link
Contributor

bwiernik commented Aug 2, 2023

@paleolimbot just bumping this

@LuisLauM
Copy link
Author

LuisLauM commented Aug 2, 2023

@paleolimbot just bumping this

Oh, I am sorry. I did not realize that the changes on my fork will be taking into account here. I just have been using the original code of @paleolimbot but introducing some features that works for me. Again, my apologizes, I will remove this thread.

@LuisLauM LuisLauM closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants