Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use GNU install dirs (should work on Windows too) #7

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

benbovy
Copy link
Collaborator

@benbovy benbovy commented Dec 14, 2022

This should fix the installed location of s2geography.dll on Windows (in the bin subdirectory instead of lib).

Copy link
Owner

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The details are over my head here but it looks reasonable to me!

@benbovy
Copy link
Collaborator Author

benbovy commented Dec 16, 2022

Thanks!

(I copied the configuration from s2geometry, which seems to work on linux / macos / windows for the conda packages).

@benbovy benbovy merged commit 68b8794 into paleolimbot:master Dec 16, 2022
benbovy added a commit to benbovy/spherely that referenced this pull request Dec 16, 2022
benbovy added a commit to benbovy/spherely that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants