Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Docker for flake8 and sphinx, and test minimum requirements #2327

Closed
wants to merge 14 commits into from
Closed

Stop using Docker for flake8 and sphinx, and test minimum requirements #2327

wants to merge 14 commits into from

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Jan 30, 2023

A few different things here. Happy to split up. Notably:

  • WTForms 1 was not being tested anyway, requirements-dev.txt has wtforms==2.3.3
  • Save installing the database containers for flake8 and doc-html
  • Test the minimum version of requirements: excercise the current compatibilty code and support maintaining existing versions while enabling newer versions. e.g. this would allow testing WTForms 2 and 3.
    Where there wasn't version information in requirements-dev.txt I picked versions that are, or could have been, in Ubuntu 20.04 and then tweaked a few to get them working together (see commit message). Clearly versions could be further adjusted.

@mrjoes
Copy link
Contributor

mrjoes commented Jan 31, 2023

I tried current master with latest flask-sqlalchemy (3.0.1) and sqlalchemy (3.0 release), which required Flask>=2.0 and tests passed. However, there are some reports that flask-admin is not compatible with Flask 2.x - it's something I did not have a chance to look at.

I believe requirements-dev.txt should be latest versions of flask-admin dependencies, while requirements-min.txt should represent lowest supported versions.

@cjmayo cjmayo force-pushed the min_reqs branch 2 times, most recently from 5e2ac13 to 1d789dd Compare January 31, 2023 20:25
@cjmayo
Copy link
Contributor Author

cjmayo commented Jan 31, 2023

I rebased on master, but couldn't repeat the passes with newer flask, flask-sqlalchemy, alchemy. I've removed as many of the restrictions as I could in requirements-dev.txt. Also:

  • Stopped Azure tests being skipped (restricting azure-storage-blob)
  • Minimum pilllow to 3.3.2, that was previously in requirements-dev.txt
  • Minimum wtforms to 2.2
  • Added support for flask_babel to tests. I tried replacing flask_babelex with flask_babel but tests didn't pass.

@cjmayo
Copy link
Contributor Author

cjmayo commented Feb 9, 2023

I think this is now ready as evidenced on #2328 - for tests to pass it needs the commits on #2332. Happy to either rebase this one after that is merged or bring those commits here and create one mega PR.

@cjmayo cjmayo mentioned this pull request Oct 16, 2023
Closed
@cjmayo cjmayo force-pushed the min_reqs branch 5 times, most recently from 37c3cf3 to 469d453 Compare October 18, 2023 18:44
@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 18, 2023

Flask and Werkzeug have moved on, breaking a far bit. New work to do to get this working again.

@cjmayo cjmayo marked this pull request as draft October 18, 2023 18:55
cjmayo added 14 commits October 19, 2023 19:38
@cjmayo
Drop unused requirements
b5bc87c
@cjmayo
Make indirect requirements clearer
53778e6
@cjmayo
Move test requirements into tox.ini
fa08f57
@cjmayo
Rename tox-version to tox-env
734f660
@cjmayo
Use Python 3.x for checks
44305b2
@cjmayo
Drop WTForms test environments
323021d
@cjmayo
Don't need services for flake8 and sphinx
c0f0c52
@cjmayo
Set permissions on workflow
6fac9ac
@cjmayo
Log information about tests that didn't pass
a25bec9
@cjmayo
Ensure Azure tests are not skipped
8d60eee 
flask_admin.contrib.fileadmin.azure uses the API of the 2.X SDK
@cjmayo
Test the minimum requirements
f1945f3 
With monogengine 0.19.1:
error in mongoengine setup command: use_2to3 is invalid.

jinja2 2.10.1 needed for flask 1.1.1

itsdangerous==2.0.1 else:
ImportError: cannot import name 'json' from 'itsdangerous'

werkzeug else:
ImportError: cannot import name 'BaseResponse' from 'werkzeug.wrappers'

Minimum version of Pillow raised in:
ecdc3e9 ("Require Pillow >= 9.1.0", 2023-10-15)
@cjmayo
flask-babelex requires pytz
bdd45d1 
.tox/py/lib/python3.10/site-packages/flask_babelex/__init__.py:25: in <module>
    from pytz.gae import pytz
E   ModuleNotFoundError: No module named 'pytz'
@cjmayo
Minimum version of sqlalchemy raised to 1.4
2c7cd11 
By:
11e828a ("Merge pull request pallets-eco#2340 from isolovey/deprecated-query-get", 2023-10-15)
@cjmayo
Make minimum requirements Python 3.11 compatible
bf22d18
@cjmayo cjmayo marked this pull request as ready for review October 19, 2023 18:50
@cjmayo
Copy link
Contributor Author

cjmayo commented Oct 19, 2023

...and 11e828a upped the minimum SQLAlchemy version supported to 1.4.

Dropped the enabling of the latest requirements to make this mergeable on its own.

@cjmayo cjmayo mentioned this pull request Oct 21, 2023
Closed
@samuelhwilliams
Copy link
Contributor

I think this is redundant now after integrating the pallets-eco GitHub action workflow files, so I will close this off.

@cjmayo cjmayo deleted the min_reqs branch July 21, 2024 18:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjmayo @mrjoes @samuelhwilliams