-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt for Tabler Template Mode #2444
base: master
Are you sure you want to change the base?
Initial attempt for Tabler Template Mode #2444
Conversation
flask-admin/flask_admin/form/widgets.py Lines 31 to 38 in 3e47879
This and other template-related codes in the Python code base might cause issues, what can we do about it? |
Yeah, interesting - feels like we'll need to give a bit of thought about how we support more modern/alternative themes like BS5 and Tabler 🤔 |
For sure! Some of the tools (advanced date picker, x-editable, Swatches, etc.) are based around bootstrap and they probably won't work with BS5, Tabler and Tailwind. I know X-Editable (#1615) doesn't work with bs5. |
We probably will also need to talk about the layout. The layout is not similar to any of the previous implementations. It is based on SQLAdmins interface - without losing any of the previous features. |
Happy to review any proposed designs/layouts - screenshots/etc would be super helpful to easily visualise what you're thinking :) |
The layout I implemented in this PR looks like this: https://sqladmin-demo.aminalaee.dev/admin/ I hope I'll make it work tomorrow and you will be able to test it with Flask Admin. |
@samuelhwilliams @hasansezertasan |
I don't think we need to ... but we could, I guess. |
I'm with @samuelhwilliams on this topic. |
Fixes #2443
Testing
I didn't include assets directly. You need NPM to install assets. To install the assets, run:
npm run build
.Notes
X-Editable
X-Editable is not maintained anymore and it doesn't support BS5 and Tabler.
I have found a fork that works with BS5 and Tabler: https://github.com/skycyclone/x-editable
But I don't feel right about it and it's not packaged on NPM. Here are related resources:
wenzhixin/bootstrap-table#5345
vitalets/x-editable#1179
My ultimate solution for a proper X-Editable alternative would be using HTMX to accomplish inline-editable features. Check out #1615.