Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge click-completion in click #1060

Closed
glehmann opened this issue Jul 4, 2018 · 4 comments
Closed

merge click-completion in click #1060

glehmann opened this issue Jul 4, 2018 · 4 comments
Labels
f:completion feature: shell completion

Comments

@glehmann
Copy link

glehmann commented Jul 4, 2018

Originally the enhancement of the completion in click was considered as better hosted in a separated project in click-contrib, but now some new completion features has been added in click, duplicating the features in click-contrib. I think it would be interesting to merge both implementations in click.

Fortunately, two different approaches have been used and I think they both have some advantages:

  • click-completion focuses on the completion at the type level
  • click focuses on the completion at the command level

as seen in click-contrib/click-completion#12 , both can be useful depending on the use case.

My hope with this issue is to:

  • validate that we actually want to merge both completions
  • discuss how to do it

in order to actually produce a pull request for the merge

@stopthatcow @Konubinix

@thechief389

This comment has been minimized.

@davidism

This comment has been minimized.

@davidism davidism added the f:completion feature: shell completion label Feb 28, 2020
@davidism
Copy link
Member

davidism commented Mar 2, 2020

I've been trying to address the open PRs about completion before 7.1, and I've come to the conclusion that Click's completion system needs a comprehensive redesign. I'd like to discuss what that looks like in #1484.

I'm not sure where click-completion fits at this point. I would love to get Click's completion support to the point where click-completion can be deprecated, and I would love to bring on the completion maintainers to help here. But I don't think I want to just copy click-completion into Click anymore. How do you feel about closing this and discussing more at #1484?

@davidism
Copy link
Member

davidism commented Jul 3, 2020

Closing in favor of #1484.

@davidism davidism closed this as completed Jul 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f:completion feature: shell completion
Projects
None yet
Development

No branches or pull requests

4 participants