Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename resultcallback to result_callback #1848

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

davidism
Copy link
Member

This is a clearer name for the decorator. The attribute is renamed to _result_callback, the only mention in the docs already implied that it shouldn't be used directly and should be set with the parameter or decorator.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 8.0.0 milestone Apr 13, 2021
@davidism davidism merged commit 0dc6d74 into master Apr 13, 2021
@davidism davidism deleted the rename-result-callback branch April 13, 2021 03:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: MultiCommand.resultcallback vs MultiCommand.result_callback
1 participant