Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typing #1887

Merged
merged 3 commits into from
May 12, 2021
Merged

Update typing #1887

merged 3 commits into from
May 12, 2021

Conversation

davidism
Copy link
Member

  • Mark imports in __init__ as exports.
  • Mark ctx.obj as Any.
  • Use typing_extensions for some types that aren't available in 3.6.0.

Checklist:

  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

davidism added 3 commits May 12, 2021 09:08
@davidism
explicit reexports
447b6bb
@davidism
ctx.obj is marked Any instead of Optional[Any]
5a74def 
This makes typing more convenient since it's a completely generic object
and won't be None if users are using it.
@davidism
fix typing that wasn't available in Python 3.6.0
5295f04
@davidism davidism added this to the 8.0.1 milestone May 12, 2021
@davidism davidism merged commit e430161 into main May 12, 2021
@davidism davidism deleted the update-typing branch May 12, 2021 16:59
@nolar nolar mentioned this pull request May 13, 2021
Closed
@davidism davidism mentioned this pull request May 19, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
typing
Projects
None yet
Milestone
8.0.1
1 participant
@davidism