From 3e4614826fa075e4d2a94e05ad060253095e53d9 Mon Sep 17 00:00:00 2001 From: Graham Inggs Date: Tue, 14 Aug 2018 19:30:23 +0200 Subject: [PATCH 1/2] Drop redundant TestLocale We have the `TestLocaleUtils` class in `tests/util/test_util.py` https://github.com/pandas-dev/pandas/blob/master/pandas/tests/util/test_util.py#L421 which is more comprehensive and includes `test_get_locales` which is functionally identical. --- pandas/tests/util/test_testing.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pandas/tests/util/test_testing.py b/pandas/tests/util/test_testing.py index dee01ab6efff6..da84973274933 100644 --- a/pandas/tests/util/test_testing.py +++ b/pandas/tests/util/test_testing.py @@ -848,18 +848,6 @@ def test_RNGContext(self): assert np.random.randn() == expected0 -class TestLocale(object): - - def test_locale(self): - if sys.platform == 'win32': - pytest.skip( - "skipping on win platforms as locale not available") - - # GH9744 - locales = tm.get_locales() - assert len(locales) >= 1 - - def test_datapath_missing(datapath, request): if not request.config.getoption("--strict-data-files"): pytest.skip("Need to set '--strict-data-files'") From 98f8a7413698a339adec96708e806a3492689ccf Mon Sep 17 00:00:00 2001 From: Graham Inggs Date: Tue, 14 Aug 2018 21:16:06 +0200 Subject: [PATCH 2/2] Preserve reference to #9744 --- pandas/tests/util/test_util.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/tests/util/test_util.py b/pandas/tests/util/test_util.py index c049dfc874940..6552655110557 100644 --- a/pandas/tests/util/test_util.py +++ b/pandas/tests/util/test_util.py @@ -455,6 +455,7 @@ def mockgetlocale(): def test_get_locales(self): # all systems should have at least a single locale + # GH9744 assert len(tm.get_locales()) > 0 def test_get_locales_prefix(self):