From 32fe030d46579742142fcb218d2285bbe19a333c Mon Sep 17 00:00:00 2001 From: Egor Dranischnikow Date: Sun, 15 Nov 2020 22:41:21 +0100 Subject: [PATCH] add comment --- pandas/_libs/src/klib/khash_python.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pandas/_libs/src/klib/khash_python.h b/pandas/_libs/src/klib/khash_python.h index aebc229abddd2..c04fe1899649d 100644 --- a/pandas/_libs/src/klib/khash_python.h +++ b/pandas/_libs/src/klib/khash_python.h @@ -16,6 +16,11 @@ // GH 13436 showed that _Py_HashDouble doesn't work well with khash // GH 28303 showed, that the simple xoring-version isn't good enough // See GH 36729 for evaluation of the currently used murmur2-hash version +// An interesting alternative to expensive murmur2-hash would be to change +// the probing strategy and use e.g. the probing strategy from CPython's +// implementation of dicts, which shines for smaller sizes but is more +// predisposed to superlinear running times (see GH 36729 for comparison) + khint64_t PANDAS_INLINE asint64(double key) { khint64_t val;