-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Fixes dataFrame to_string(header=False) #49738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+21
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 17, 2022
doc/source/whatsnew/v2.0.0.rst
Outdated
@@ -692,7 +692,9 @@ I/O | |||
- Improved error message in :func:`read_excel` by including the offending sheet name when an exception is raised while reading a file (:issue:`48706`) | |||
- Bug when a pickling a subset PyArrow-backed data that would serialize the entire data instead of the subset (:issue:`42600`) | |||
- Bug in :func:`read_csv` for a single-line csv with fewer columns than ``names`` raised :class:`.errors.ParserError` with ``engine="c"`` (:issue:`47566`) | |||
- Bug in :func:`adjoin` used for DataFrame.to_string(header=False) printed index.name on the same line as the first row of the data (:issue: ``49230``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Bug in :func:`adjoin` used for DataFrame.to_string(header=False) printed index.name on the same line as the first row of the data (:issue: ``49230``) | |
- Bug in :func:`DataFrame.to_string` with ``header=False`` that printed the index name on the same line as the first row of the data (:issue:`49230`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the release note.
mroeschke
approved these changes
Nov 17, 2022
Nice fix @andrewchen1216! |
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
* BUG: GH49230 to_string(header=False) fix * TST:Updated and Added Test Cases for GH49230 * DOC: Added release notes documentation * DOC:Updated release notes
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* BUG: GH49230 to_string(header=False) fix * TST:Updated and Added Test Cases for GH49230 * DOC: Added release notes documentation * DOC:Updated release notes
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes BUG: to_string(header=False) should not shift the index w.r.t. the data #49230
[Tests added and passed] if fixing a bug or adding a new feature
All [code checks passed].
Added an entry in the latest
doc/source/whatsnew/v2.0.0.rst
file if fixing a bug or adding a new feature.