From 01208c53eed2deab2afcbd6587499679342872a3 Mon Sep 17 00:00:00 2001 From: Riley Brady Date: Thu, 8 Oct 2020 13:51:13 -0600 Subject: [PATCH 1/3] break test --- climpred/tests/test_stats.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/climpred/tests/test_stats.py b/climpred/tests/test_stats.py index d43c369e7..5b2512a46 100644 --- a/climpred/tests/test_stats.py +++ b/climpred/tests/test_stats.py @@ -13,7 +13,7 @@ def test_dpp(PM_da_control_3d, chunk): """Check for positive diagnostic potential predictability in NA SST.""" res = dpp(PM_da_control_3d, chunk=chunk) - assert res.mean() > 0 + assert res.mean() < 0 @pytest.mark.parametrize("func", (varweighted_mean_period, decorrelation_time)) From db85fb33bf2156f984618dc665f4c022db496d99 Mon Sep 17 00:00:00 2001 From: Riley Brady Date: Thu, 8 Oct 2020 14:00:35 -0600 Subject: [PATCH 2/3] fix test --- climpred/tests/test_stats.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/climpred/tests/test_stats.py b/climpred/tests/test_stats.py index 5b2512a46..d43c369e7 100644 --- a/climpred/tests/test_stats.py +++ b/climpred/tests/test_stats.py @@ -13,7 +13,7 @@ def test_dpp(PM_da_control_3d, chunk): """Check for positive diagnostic potential predictability in NA SST.""" res = dpp(PM_da_control_3d, chunk=chunk) - assert res.mean() < 0 + assert res.mean() > 0 @pytest.mark.parametrize("func", (varweighted_mean_period, decorrelation_time)) From f9a0177f6b2a4e4d1a5825ad2caaa88e0a9127b8 Mon Sep 17 00:00:00 2001 From: Riley Brady Date: Thu, 8 Oct 2020 14:21:13 -0600 Subject: [PATCH 3/3] update codecov action --- .github/workflows/climpred_testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/climpred_testing.yml b/.github/workflows/climpred_testing.yml index a46bc8849..c5405af6e 100644 --- a/.github/workflows/climpred_testing.yml +++ b/.github/workflows/climpred_testing.yml @@ -33,7 +33,7 @@ jobs: conda activate climpred-minimum-tests pytest --cov=climpred --cov-report=xml - name: Upload coverage to codecov - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v1.0.5 with: file: ./coverage.xml fail_ci_if_error: true