From 4dd3518cc079843c809941769c264a3daebc2cf5 Mon Sep 17 00:00:00 2001 From: Riley Brady Date: Thu, 8 Oct 2020 14:45:49 -0600 Subject: [PATCH 1/3] try updating codecov --- .github/workflows/climpred_testing.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/climpred_testing.yml b/.github/workflows/climpred_testing.yml index a46bc8849..0b8b1cfb3 100644 --- a/.github/workflows/climpred_testing.yml +++ b/.github/workflows/climpred_testing.yml @@ -33,7 +33,7 @@ jobs: conda activate climpred-minimum-tests pytest --cov=climpred --cov-report=xml - name: Upload coverage to codecov - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v1.0.7 with: file: ./coverage.xml fail_ci_if_error: true From be9afd874ba554c5c1a78780034b51b593b371e2 Mon Sep 17 00:00:00 2001 From: Riley Brady Date: Thu, 8 Oct 2020 15:04:57 -0600 Subject: [PATCH 2/3] explicitly use codecov token --- .github/workflows/climpred_testing.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/climpred_testing.yml b/.github/workflows/climpred_testing.yml index 0b8b1cfb3..167a5bd70 100644 --- a/.github/workflows/climpred_testing.yml +++ b/.github/workflows/climpred_testing.yml @@ -35,6 +35,7 @@ jobs: - name: Upload coverage to codecov uses: codecov/codecov-action@v1.0.7 with: + token: ${{ secrets.CODECOV_TOKEN }} file: ./coverage.xml fail_ci_if_error: true From f87d2d7f9435b89bf9f901ef98b801e6748167ef Mon Sep 17 00:00:00 2001 From: Riley Brady Date: Thu, 8 Oct 2020 15:19:11 -0600 Subject: [PATCH 3/3] only run on pull request --- .github/workflows/climpred_installs.yml | 2 +- .github/workflows/climpred_testing.yml | 4 ++-- .github/workflows/lint.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/climpred_installs.yml b/.github/workflows/climpred_installs.yml index 59082d6f7..606489f24 100644 --- a/.github/workflows/climpred_installs.yml +++ b/.github/workflows/climpred_installs.yml @@ -1,6 +1,6 @@ name: climpred installs -on: [push, pull_request_target] +on: pull_request_target jobs: install-climpred: # Installs climpred on various OS. diff --git a/.github/workflows/climpred_testing.yml b/.github/workflows/climpred_testing.yml index 167a5bd70..667dee443 100644 --- a/.github/workflows/climpred_testing.yml +++ b/.github/workflows/climpred_testing.yml @@ -1,6 +1,6 @@ name: climpred testing -on: [push, pull_request_target] +on: pull_request_target jobs: test: # Runs testing suite on various python versions. @@ -37,7 +37,7 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} file: ./coverage.xml - fail_ci_if_error: true + fail_ci_if_error: false docs_notebooks: # Checks that pre-compiled notebooks in docs still work. runs-on: ubuntu-latest diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index bfddea160..26a4e3274 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,6 +1,6 @@ name: Lint -on: [push, pull_request_target] +on: pull_request_target jobs: lint: # Runs linting package checks for code styling.