Skip to content

Commit

Permalink
fix: Updating used module versions (Azure#3604)
Browse files Browse the repository at this point in the history
## Description

Updating used module versions.

Fixes Azure#3569 
Closes Azure#3569 


## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.network.hub-networking](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.ptn.network.hub-networking.yml/badge.svg?branch=fix%2Fissues%2F3569)](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.ptn.network.hub-networking.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [X] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [X] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [X] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Máté Barabás <barabasmate@gmail.com>
Co-authored-by: Rainer Halanek <61878316+rahalan@users.noreply.github.com>
Co-authored-by: JFolberth <johnfolberth@gmail.com>
  • Loading branch information
4 people authored Oct 22, 2024
1 parent fd66bef commit 0e43ed0
Show file tree
Hide file tree
Showing 3 changed files with 421 additions and 384 deletions.
6 changes: 3 additions & 3 deletions avm/ptn/network/hub-networking/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This module is designed to simplify the creation of multi-region hub networks in
| `Microsoft.Authorization/locks` | [2020-05-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2020-05-01/locks) |
| `Microsoft.Authorization/roleAssignments` | [2022-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2022-04-01/roleAssignments) |
| `Microsoft.Insights/diagnosticSettings` | [2021-05-01-preview](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Insights/2021-05-01-preview/diagnosticSettings) |
| `Microsoft.Network/azureFirewalls` | [2023-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2023-04-01/azureFirewalls) |
| `Microsoft.Network/azureFirewalls` | [2024-01-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/azureFirewalls) |
| `Microsoft.Network/bastionHosts` | [2022-11-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2022-11-01/bastionHosts) |
| `Microsoft.Network/publicIPAddresses` | [2023-09-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2023-09-01/publicIPAddresses) |
| `Microsoft.Network/routeTables` | [2023-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2023-04-01/routeTables) |
Expand Down Expand Up @@ -2203,10 +2203,10 @@ This section gives you an overview of all local-referenced module files (i.e., o

| Reference | Type |
| :-- | :-- |
| `br/public:avm/res/network/azure-firewall:0.5.0` | Remote reference |
| `br/public:avm/res/network/azure-firewall:0.5.1` | Remote reference |
| `br/public:avm/res/network/bastion-host:0.4.0` | Remote reference |
| `br/public:avm/res/network/route-table:0.4.0` | Remote reference |
| `br/public:avm/res/network/virtual-network:0.4.0` | Remote reference |
| `br/public:avm/res/network/virtual-network:0.5.0` | Remote reference |

## Data Collection

Expand Down
4 changes: 2 additions & 2 deletions avm/ptn/network/hub-networking/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ resource avmTelemetry 'Microsoft.Resources/deployments@2023-07-01' = if (enableT
}

// Create hub virtual networks
module hubVirtualNetwork 'br/public:avm/res/network/virtual-network:0.4.0' = [
module hubVirtualNetwork 'br/public:avm/res/network/virtual-network:0.5.0' = [
for (hub, index) in items(hubVirtualNetworks ?? {}): {
name: '${uniqueString(deployment().name, location)}-${hub.key}-nvn'
params: {
Expand Down Expand Up @@ -166,7 +166,7 @@ module hubBastion 'br/public:avm/res/network/bastion-host:0.4.0' = [

// Create Azure Firewall if enabled
// AzureFirewallSubnet is required to deploy Azure Firewall service. This subnet must exist in the subnets array if you enable Azure Firewall.
module hubAzureFirewall 'br/public:avm/res/network/azure-firewall:0.5.0' = [
module hubAzureFirewall 'br/public:avm/res/network/azure-firewall:0.5.1' = [
for (hub, index) in items(hubVirtualNetworks ?? {}): if (hub.value.enableAzureFirewall) {
name: '${uniqueString(deployment().name, location)}-${hub.key}-naf'
params: {
Expand Down
Loading

0 comments on commit 0e43ed0

Please sign in to comment.