Use inline style system to add admin bar styles to page #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
ataylorme
approved these changes
Sep 8, 2019
danielbachhuber
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improve the logic for injecting the admin bar styles into the page. Instead of manually adding a
styleelement to the page, amend the inline styles for theadmin-barwith the HUD styles. This results in the HUD styles being combined with any other inline styles for the admin bar.This also results in the styles being automatically opted-in for the new dev mode in the AMP plugin: ampproject/amp-wp#3187. Otherwise, a
data-ampdevmodeattribute would need to be added to thestyleelement. But if using the inline style system, then the AMP plugin will automatically flag it as being part of dev mode.