From 55e6908a1b02848b24d262520216458bfa29fc50 Mon Sep 17 00:00:00 2001 From: Danny McClanahan <1305167+cosmicexplorer@users.noreply.github.com> Date: Tue, 4 Dec 2018 18:13:03 -0800 Subject: [PATCH] add TODO links --- src/python/pants/backend/native/subsystems/binaries/gcc.py | 2 +- .../pants_test/backend/python/tasks/test_ctypes_integration.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/python/pants/backend/native/subsystems/binaries/gcc.py b/src/python/pants/backend/native/subsystems/binaries/gcc.py index 29a3ca2463d..5f48e12fb85 100644 --- a/src/python/pants/backend/native/subsystems/binaries/gcc.py +++ b/src/python/pants/backend/native/subsystems/binaries/gcc.py @@ -75,7 +75,7 @@ def _cpp_include_dirs(self): ('include/c++', self.version()), ]) - # TODO: determine whether there is any manual explaining when any of these file paths are + # TODO(#6143): determine whether there is any manual explaining when any of these file paths are # necessary. # This file is needed for C++ compilation. cpp_config_header_path = self._file_mapper.assert_single_path_by_glob( diff --git a/tests/python/pants_test/backend/python/tasks/test_ctypes_integration.py b/tests/python/pants_test/backend/python/tasks/test_ctypes_integration.py index cbbb3b090f5..b186cccb986 100644 --- a/tests/python/pants_test/backend/python/tasks/test_ctypes_integration.py +++ b/tests/python/pants_test/backend/python/tasks/test_ctypes_integration.py @@ -77,6 +77,7 @@ def _assert_ctypes_binary(self, toolchain_variant): # Check that we have selected the appropriate compilers for our selected toolchain variant, # for both C and C++ compilation. + # TODO(#6866): don't parse info logs for testing! for compiler_name in self._compiler_names_for_variant[toolchain_variant]: self.assertIn("selected compiler exe name: '{}'".format(compiler_name), pants_run.stdout_data)