From acf809bb3fc70060ac474867ff6159d64328401c Mon Sep 17 00:00:00 2001 From: Asher Foa <1268088+asherf@users.noreply.github.com> Date: Wed, 27 Jul 2022 10:44:58 -0400 Subject: [PATCH] Remove advanced flags from python-repos subsystems Currently, if you try to get help for this subsystem, `./pants help python-repos` you will get nothing useful and the user needs to repeat the command with the help-advanced directive (happened to me right now). My thinking is: It is somewhat pointless to have a subsystem where all the options are advanced, it makes sense if there are multiple options and some are advanced and some or not. But I don't think we should allow options scopes that only have advanced options since it a little confusing to users trying to get help about it. This is just an opinion, feel free to close this PR. --- src/python/pants/backend/python/subsystems/repos.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/python/pants/backend/python/subsystems/repos.py b/src/python/pants/backend/python/subsystems/repos.py index b89a2a635fa..5c6bf4e8212 100644 --- a/src/python/pants/backend/python/subsystems/repos.py +++ b/src/python/pants/backend/python/subsystems/repos.py @@ -29,7 +29,6 @@ class PythonRepos(Subsystem): corresponds to the `--find-links` option. """ ), - advanced=True, ) indexes = StrListOption( default=[pypi_index], @@ -40,7 +39,6 @@ class PythonRepos(Subsystem): should be compliant with PEP 503. """ ), - advanced=True, ) @property