go: add support for test coverage #16550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Aug 17, 2022
| ) | ||
|
|
||
| _coverage_output_dir = StrOption( | ||
| default=str(PurePath("{distdir}", "coverage", "go", "{import_path_escaped}")), |
There was a problem hiding this comment.
Hm... I'm surprised that you need this prefix... I guess that the test goal doesn't add it?
IIRC, @benjyw refactored the report output location to have a default, which would probably be reasonable to do here too if it makes things easier for you.
There was a problem hiding this comment.
The test goal does not influence the output location. I based this code on the option code in the Python backend which supplies the path prefix itself. See
pants/src/python/pants/backend/python/goals/coverage_py.py
Lines 150 to 154 in 28d756e
tdyas
commented
Aug 19, 2022
tdyas
commented
Aug 19, 2022
added 8 commits
August 20, 2022 20:07
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
of the test package only and `go` leaves this value blank in that case [ci skip-rust] [ci skip-build-wheels]
[ci skip-rust] [ci skip-build-wheels]
tdyas
force-pushed
the
golang_test_coverage
branch
from
74d7be4 to
c47c486
Compare
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Update the Go backend to gather code coverage data for packages under test. The coverage files are written under `dist/coverage/go/IMPORT_PATH` directories (where `IMPORT_PATH` has slashes escaped to underscores). The coverage output is the raw `cover.out` format from the `go` tooling and is not rendered by this PR (which can be done in a follow-on since it is a bit involved). [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Go backend to gather code coverage data for packages under test. The coverage files are written under
dist/coverage/go/IMPORT_PATHdirectories (whereIMPORT_PATHhas slashes escaped to underscores). The coverage output is the rawcover.outformat from thegotooling and is not rendered by this PR (which can be done in a follow-on since it is a bit involved).[ci skip-rust]
[ci skip-build-wheels]