Fix performance for generating lockfiles for pytest and setuptools
#16591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
approved these changes
Aug 19, 2022
Comment on lines
-199
to
-200
| # If no Python targets in repo, fall back to MyPy constraints. | ||
| assert_lockfile_request("target()", MyPy.default_interpreter_constraints) |
There was a problem hiding this comment.
I don't quite understand this change. But if there are no python targets in the repository, then it probably doesn't matter which we use...?
There was a problem hiding this comment.
It's because the rule helper says or python_setup.interpreter_constraints when there were no interpreter constraints. Whereas the old bespoke code said or mypy.interpretre_constraints. That's pretty unlikely to happen -- it's only when there are zero MyPy compatible targets in the repo.
Eric-Arellano
added a commit
to Eric-Arellano/pants
that referenced
this pull request
Aug 20, 2022
pantsbuild#16591) Follow up to pantsbuild#15531. We didn't apply the optimization for Pytest and setuptools that it is no longer necessary to consult `TransitiveTargets` to determine interpreter constraints for `generate-lockfiles`, purely out of oversight. This also leverages `@rule_helper` to DRY some of our interpreter constraints code for lockfiles. That results in these slight behavior changes: * MyPy and Black are fixed to properly OR distinct interpreter constraints. We always meant to do this. * If MyPy does not encounter any MyPy-compatible targets in the repo, we fall back to `[python].interpreter_constraints` rather than the default `[mypy].interpreter_constraints`. This situation is unlikely to happen. In `pantsbuild/pants`, it now takes us 0.4 seconds rather than 4.7 seconds to calculate the interpreter constraints for `./pants generate-lockfiles --resolve=pytest`. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Aug 22, 2022
…` (Cherry-pick of #16591) (#16596) Follow up to #15531. We didn't apply the optimization for Pytest and setuptools that it is no longer necessary to consult `TransitiveTargets` to determine interpreter constraints for `generate-lockfiles`, purely out of oversight. This also leverages `@rule_helper` to DRY some of our interpreter constraints code for lockfiles. That results in these slight behavior changes: * MyPy and Black are fixed to properly OR distinct interpreter constraints. We always meant to do this. * If MyPy does not encounter any MyPy-compatible targets in the repo, we fall back to `[python].interpreter_constraints` rather than the default `[mypy].interpreter_constraints`. This situation is unlikely to happen. In `pantsbuild/pants`, it now takes us 0.4 seconds rather than 4.7 seconds to calculate the interpreter constraints for `./pants generate-lockfiles --resolve=pytest`. [ci skip-rust] [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
pantsbuild#16591) Follow up to pantsbuild#15531. We didn't apply the optimization for Pytest and setuptools that it is no longer necessary to consult `TransitiveTargets` to determine interpreter constraints for `generate-lockfiles`, purely out of oversight. This also leverages `@rule_helper` to DRY some of our interpreter constraints code for lockfiles. That results in these slight behavior changes: * MyPy and Black are fixed to properly OR distinct interpreter constraints. We always meant to do this. * If MyPy does not encounter any MyPy-compatible targets in the repo, we fall back to `[python].interpreter_constraints` rather than the default `[mypy].interpreter_constraints`. This situation is unlikely to happen. In `pantsbuild/pants`, it now takes us 0.4 seconds rather than 4.7 seconds to calculate the interpreter constraints for `./pants generate-lockfiles --resolve=pytest`. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15531. We didn't apply the optimization for Pytest and setuptools that it is no longer necessary to consult
TransitiveTargetsto determine interpreter constraints forgenerate-lockfiles, purely out of oversight.This also leverages
@rule_helperto DRY some of our interpreter constraints code for lockfiles. That results in these slight behavior changes:[python].interpreter_constraintsrather than the default[mypy].interpreter_constraints. This situation is unlikely to happen.In
pantsbuild/pants, it now takes us 0.4 seconds rather than 4.7 seconds to calculate the interpreter constraints for./pants generate-lockfiles --resolve=pytest.[ci skip-rust]
[ci skip-build-wheels]