Streamline CI #17224
Streamline CI #17224
Conversation
benjyw
force-pushed
the
streamline_ci
branch
2 times, most recently
from
e0e42b7 to
6e88bbe
Compare
|
Still need to figure out why the "Set Merge OK" job didn't run. It depends on skipped jobs, but the github docs say "Note: A job that is skipped will report its status as "Success". It will not prevent a pull request from merging, even if it is a required check." : https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution |
|
Annoyingly, a skipped job counts as successful for the purpose of branch protection, but jobs that depend on it still don't run. Working around this now. The workaround might actually allow us to simplify the merge-ok dance. |
| "github.event_name == 'push' || !contains(env.COMMIT_MESSAGE, '[ci skip-build-wheels]')" | ||
| ) | ||
|
|
||
| DONT_SKIP_RUST = "needs.classify_changes.outputs.rust == true" |
There was a problem hiding this comment.
Oh. Hm... I just realized that your classification changes made
pants/build-support/githooks/prepare-commit-msg
Lines 19 to 42 in 04282f7
There was a problem hiding this comment.
Yep! Planning to remove those in a followup.
| # For manylinux compatibility, we build wheels in a container rather than directly | ||
| # on the Ubuntu runner. As a result, we have custom steps here to check out | ||
| # the code, install rustup and expose Pythons. | ||
| # TODO: Run tests etc. using this container image, so we can reuse the rust engine build? |
There was a problem hiding this comment.
Tests run in debug mode by default, so they won't share any compilation with production/release wheel builds. The only time you would have overlap would be in PR runs that affected wheel builds... probably not worth it to try and share between tests and release builds.
There was a problem hiding this comment.
Makes sense, will adjust the comment
There was a problem hiding this comment.
But we could still profitably cache cargo etc presumably?
[ci skip-build-wheels]
- Unifies the code that generates the "Build wheels" jobs, so they are now uniform (with allowances for the containerization on Linux). This means in particular that we no longer bootstrap Pants on macOS11 on ARM64, as there was no particular reason to, and we weren't doing so on macOS10.15 on x86 for example. - Uses the new classifier to skip these jobs entirely if unneeded. - Similarly, uses the new classifier to skip rust steps if unneeded. - Removes the steps for getting the commit message, since we no longer need it. Now, to force a rust or wheel build even if no files were affected, you can temporarily modify a relevant file. If this becomes a hassle we can think of another way to achieve this, that doesn't involve the commit message.
- Unifies the code that generates the "Build wheels" jobs, so they are now uniform (with allowances for the containerization on Linux). This means in particular that we no longer bootstrap Pants on macOS11 on ARM64, as there was no particular reason to, and we weren't doing so on macOS10.15 on x86 for example. - Uses the new classifier to skip these jobs entirely if unneeded. - Similarly, uses the new classifier to skip rust steps if unneeded. - Removes the steps for getting the commit message, since we no longer need it. Now, to force a rust or wheel build even if no files were affected, you can temporarily modify a relevant file. If this becomes a hassle we can think of another way to achieve this, that doesn't involve the commit message.
Now, to force a rust or wheel build even if no files were affected, you can temporarily modify a relevant file. If this becomes a hassle we can think of another way to achieve this, that doesn't involve the commit message.