Switch to [lambdex].layout = "zip" by default, deprecating the section #19122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
changed the title
huonw
force-pushed
the
feature/18879-zip-by-default
branch
from
316d1c2 to
4023b6d
Compare
benjyw
approved these changes
May 25, 2023
| removal_version="2.19.0.dev0", | ||
| removal_hint=softwrap( | ||
| """ | ||
| Remove the whole [lambdex] section, as Lambdex is deprecated and its functionality be |
There was a problem hiding this comment.
Suggested change
| Remove the whole [lambdex] section, as Lambdex is deprecated and its functionality be | |
| Remove the whole [lambdex] section, as Lambdex is deprecated and its functionality will be |
There was a problem hiding this comment.
Honestly no need to change this and trigger a new CI run, can tweak it in a future change, and merge as-is now.
There was a problem hiding this comment.
Added to #19067 as a reminder.
This was referenced May 30, 2023
huonw
added a commit
that referenced
this pull request
Jun 1, 2023
This renames the `python_awslambda` target to `python_aws_lambda_function`. This is to reduce ambiguity now that Pants has support for building layers via `python_aws_lambda_layer` (#19123), in addition to functions, and also aligns with the `python_google_cloud_function` target too. This change has a single release deprecation since it's easy to fix, and keeps it inline with the layout switch over (e.g. #19122), but it's also easy to keep around for longer. This PR essentially just does a search and replace on the documentation, it doesn't update the docs to include info about layers. I'm working on that separately.
huonw
added a commit
that referenced
this pull request
Jun 1, 2023
This updates the AWS Lambda and Google Cloud Functions documentation to be appropriate for Pants 2.18, which includes: - updates for the migration from Lambdex to 'native'/zip (continuing #19067 and #19122) - describing how to build a Lambda layer (documenting #19123) - updating the AWS Lambda docs for renaming from `python_awslambda` to `python_aws_lambda_function` (finishing off #19216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #18879 / #19076, by switching to the new
ziplayout by default, for 2.18. This also deprecates the option entirely, telling users to remove the[lambdex]section.As a reminder, the phasing is:
layout = "lambdex"is implicit, tell people to set it: recommendzip, but allowlambdexif they have tolayoutis set, tell people to remove it and thus switch to (implicit)zip[lambdex]section entirely)