Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the version/extra_requirements options on python tools. (Cherry-pick of #19204) #19211

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Deprecate the version/extra_requirements options on python tools. (Cherry-pick of #19204) #19211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/python/pants/backend/python/subsystems/python_tool_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,25 @@ class PythonToolRequirementsBase(Subsystem):
version = StrOption(
advanced=True,
default=lambda cls: cls.default_version,
removal_version="2.18.0.dev1",
removal_hint=lambda cls: softwrap(
f"""\
Custom tool versions are now installed from named resolves, as
described at {doc_url("python-lockfiles")}.
"""
),
help="Requirement string for the tool.",
)
extra_requirements = StrListOption(
advanced=True,
default=lambda cls: cls.default_extra_requirements,
removal_version="2.18.0.dev1",
removal_hint=lambda cls: softwrap(
f"""\
Custom tool versions are now installed from named resolves, as
described at {doc_url("python-lockfiles")}.
"""
),
help="Any additional requirement strings to use with the tool. This is useful if the "
"tool allows you to install plugins or if you need to constrain a dependency to "
"a certain version.",
Expand Down