-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keybindings to switch to ws from all monitors #687
Add keybindings to switch to ws from all monitors #687
Conversation
without actually setting the space.monitor to it. I.e. only set the monitor to a space if it's actually selected.
@jtaala btw during testing I noticed that the workspace indicator on the secondary display looked strange. But I don't think this has anything to do with this PR. |
Thanks @Lythenas. I'm trying to find the issue where something similar was mentioned when using custom styles (so might not be like here) and using workspace colours (not the default gnome shell background). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested and appears to work well!
Nice job!
Hey @Lythenas have approved. Feel free to merge when ready. |
You appear to be using custom styling? (just looks like it since the window selection is an orange colour instead of the default blue). If so, can you share the styling? or might it be another extension (like blur-my-shell or just-perfection etc.?). |
@jtaala I can't merge. So feel free to merge yourself. It says:
Regarding your question: I can't find a user.css in the VM where I tested. Also no other extension is enabled, only PaperWM and Ubuntu AppIndicators. I think I just changed the color in the gnome settings (but maybe it was the default): |
No dang it - I fixed this (but for develop branch) - forgot about gnome branches. |
Okay, should have fixed it for gnome branches. I'll merge anyways. |
Gnome 44 port of #645