Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybindings to switch to ws from all monitors #687

Merged

Conversation

Lythenas
Copy link
Collaborator

Gnome 44 port of #645

Fixes #635

Adds two new keybindings:

Switch to workspace below (ws from all monitors)
Switch to workspace above (ws from all monitors)

by default they have no keys bound.

They work the same as "Switch to workspace below/above (ws only from current monitor)" (renamed from just "Switch to workspace below/above"). Except the user can switch to all workspaces (except the once currently active on another monitor).

Please test this.

@Lythenas
Copy link
Collaborator Author

@jtaala btw during testing I noticed that the workspace indicator on the secondary display looked strange. But I don't think this has anything to do with this PR.

Screenshot from 2023-11-12 12-59-48

@Lythenas Lythenas requested a review from jtaala November 12, 2023 12:05
@jtaala
Copy link
Collaborator

jtaala commented Nov 13, 2023

@jtaala btw during testing I noticed that the workspace indicator on the secondary display looked strange. But I don't think this has anything to do with this PR.

Screenshot from 2023-11-12 12-59-48

Thanks @Lythenas. I'm trying to find the issue where something similar was mentioned when using custom styles (so might not be like here) and using workspace colours (not the default gnome shell background).

Copy link
Collaborator

@jtaala jtaala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested and appears to work well!

Nice job!

@jtaala
Copy link
Collaborator

jtaala commented Nov 13, 2023

Hey @Lythenas have approved. Feel free to merge when ready.

@jtaala
Copy link
Collaborator

jtaala commented Nov 13, 2023

@jtaala btw during testing I noticed that the workspace indicator on the secondary display looked strange. But I don't think this has anything to do with this PR.
Screenshot from 2023-11-12 12-59-48

Thanks @Lythenas. I'm trying to find the issue where something similar was mentioned when using custom styles (so might not be like here) and using workspace colours (not the default gnome shell background).

You appear to be using custom styling? (just looks like it since the window selection is an orange colour instead of the default blue). If so, can you share the styling? or might it be another extension (like blur-my-shell or just-perfection etc.?).

@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Nov 13, 2023
@Lythenas
Copy link
Collaborator Author

@jtaala I can't merge. So feel free to merge yourself. It says:

The base branch restricts merging to authorized users

Regarding your question: I can't find a user.css in the VM where I tested. Also no other extension is enabled, only PaperWM and Ubuntu AppIndicators. I think I just changed the color in the gnome settings (but maybe it was the default):

Screenshot from 2023-11-13 18-00-40

@jtaala
Copy link
Collaborator

jtaala commented Nov 14, 2023

@jtaala I can't merge. So feel free to merge yourself. It says:

The base branch restricts merging to authorized users

No dang it - I fixed this (but for develop branch) - forgot about gnome branches.

@jtaala
Copy link
Collaborator

jtaala commented Nov 14, 2023

Okay, should have fixed it for gnome branches. I'll merge anyways.

@jtaala jtaala merged commit edaaaa5 into paperwm:gnome-44 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants