Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: ensure fullscreened windows above "above" modal dialogs #903

Merged
merged 6 commits into from
Jul 27, 2024
Merged

FIX: ensure fullscreened windows above "above" modal dialogs #903

merged 6 commits into from
Jul 27, 2024

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Jul 21, 2024

Resolves #902.

This PR simply ensures that when a window is fullscreened, it's set "above" other windows (namely, modal dialog windows).

@jtaala
Added a metawindow property to track "above" state when fullscreened.
109c58a 
After fullscreening, we "make_above()" on the window to ensure if it
above other windows (namely, modal windows).
@jtaala jtaala linked an issue Jul 21, 2024 that may be closed by this pull request
Pop-up (modal) windows are above fullscreened windows #902
Closed
@jtaala jtaala marked this pull request as draft July 21, 2024 03:08
@jtaala jtaala added the seeking-feedback Seeking feedback from other PaperWM users label Jul 21, 2024
@jtaala jtaala mentioned this pull request Jul 21, 2024
Closed
jtaala and others added 3 commits July 21, 2024 13:11
@jtaala jtaala marked this pull request as ready for review July 21, 2024 06:23
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Jul 23, 2024
Lythenas
Lythenas approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Lythenas Lythenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine.

Although for me even without this, the dialog was always under the fullscreen window. But I only tried a couple of dialogs and a firefox fullscreen window.

@Lythenas
Copy link
Collaborator

@vinhor since this is supposed to fix your issue, it would be good if you could test if it actually does.

@jtaala jtaala merged commit 4c58c6f into develop Jul 27, 2024
@jtaala jtaala deleted the improve-fullscreen-windows-set-always-on-top branch July 27, 2024 00:40
@vinhor
Copy link

vinhor commented Aug 4, 2024

Tried it and it works!
Thanks you all for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lythenas Lythenas Lythenas approved these changes

Assignees
No one assigned
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week) seeking-feedback Seeking feedback from other PaperWM users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pop-up (modal) windows are above fullscreened windows
3 participants
@jtaala @Lythenas @vinhor