Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement completionItem/resolve #56

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

krassowski
Copy link
Contributor

@krassowski krassowski commented Jan 31, 2021

  • Implemented completionItem/resolve; the Jedi completion data are held until the next textDocument/completion arrives
  • Added completion.resolveEagerly option to allow users to opt out of the change (in anticipation for their editor to support completionItem/resolve if it does not already)
  • Tested

Following up on #45 (comment).

Copy link
Owner

@pappasam pappasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pappasam
Copy link
Owner

pappasam commented Feb 1, 2021

@krassowski Excellent implementation and thanks for pushing the completion/resolve idea. I've noticed a slight improvement for numpy completions. Creating a release now, let me know how things work in the wild for you!

@pappasam pappasam merged commit 4effbb8 into pappasam:master Feb 1, 2021
@krassowski
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants