Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor random_blocks function #10457

Closed
jenpaff opened this issue Aug 22, 2024 · 0 comments · Fixed by #10563
Closed

Refactor random_blocks function #10457

jenpaff opened this issue Aug 22, 2024 · 0 comments · Fixed by #10563
Assignees
@jenpaff
Labels
C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test

Comments

@jenpaff
Copy link
Collaborator

jenpaff commented Aug 22, 2024 •
edited
Loading

random_block(s) function arguments is growing too big, we should refactor this into using struct for optional fields

see #10428 (review)
@jenpaff jenpaff mentioned this issue Aug 22, 2024
Closed
@jenpaff jenpaff self-assigned this Aug 22, 2024
@jenpaff jenpaff mentioned this issue Aug 22, 2024
Merged
@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test labels Aug 22, 2024
This was referenced Aug 24, 2024
Closed
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenpaff jenpaff

Labels
C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test
Projects
Reth Tracker
Archived in project
Milestone
No milestone
2 participants
@jenpaff @shekhirin