Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data to RpcInvalidTransactionError::InsufficientFunds #10732

Closed
Tracked by #10464
emhane opened this issue Sep 5, 2024 · 2 comments · Fixed by #10872
Closed
Tracked by #10464

Add data to RpcInvalidTransactionError::InsufficientFunds #10732

emhane opened this issue Sep 5, 2024 · 2 comments · Fixed by #10872
Assignees
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior

Comments

@emhane
Copy link
Member

emhane commented Sep 5, 2024

Describe the feature

Add necessary data to error variant to produce error message like geth 'failed with 50000000 gas: insufficient funds for gas * price + value: address 0x889eBDAc39408782B5165c5185C1A769B4Dd3ce6 have 1444840609176611 want 2652000000000000'

/// Represents the inability to cover max cost + value (account balance too low).
#[error("insufficient funds for gas * price + value")]
InsufficientFunds,

Additional context

No response

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Sep 5, 2024
@mvares
Copy link
Contributor

mvares commented Sep 6, 2024

@emhane, do you think we should add as key of enum or using only format! in this case?

@emhane
Copy link
Member Author

emhane commented Sep 12, 2024

don't get the question tbh @mvares

@emhane emhane self-assigned this Sep 12, 2024
@emhane emhane added C-bug An unexpected or incorrect behavior and removed C-debt Refactor of code section that is hard to understand or maintain labels Sep 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants