Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split apply preblock functions into two #10953

Closed
mattsse opened this issue Sep 17, 2024 · 0 comments · Fixed by #11068
Closed

split apply preblock functions into two #10953

mattsse opened this issue Sep 17, 2024 · 0 comments · Fixed by #11068
Assignees
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 17, 2024

Describe the feature

we'd like to have this as two functions, one that commits, and one that doesn't

pub fn apply_beacon_root_contract_call<EvmConfig, EXT, DB>(
evm_config: &EvmConfig,
chain_spec: &ChainSpec,
block_timestamp: u64,
block_number: u64,
parent_beacon_block_root: Option<B256>,
evm: &mut Evm<'_, EXT, DB>,
) -> Result<(), BlockExecutionError>
where
DB: Database + DatabaseCommit,
DB::Error: core::fmt::Display,
EvmConfig: ConfigureEvm,
{

Additional context

ref #10877

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 17, 2024
@mattsse mattsse self-assigned this Sep 17, 2024
@mattsse mattsse added A-execution Related to the Execution and EVM and removed S-needs-triage This issue needs to be labelled labels Sep 17, 2024
@mattsse mattsse closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant