Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write transactions to static files on insert_historical_block #11524

Open
joshieDo opened this issue Oct 7, 2024 · 1 comment
Open

Write transactions to static files on insert_historical_block #11524

joshieDo opened this issue Oct 7, 2024 · 1 comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-needs-investigation This issue requires detective work to figure out what's going wrong

Comments

@joshieDo
Copy link
Collaborator

joshieDo commented Oct 7, 2024

Describe the feature

Writing transactions to static files on insert_historical_block tried on #11523 (05cf701) triggered a bunch of errors in other tests.

Many tests across the test-suite are assuming that transactions are on database instead of static files. This should change especially with the introduction of the new engine, given that transactions will start getting written directly to static files. (they already do during staged sync)

When done, remove the transaction writer from provider_with_chain_spec_and_random_blocks introduced on the above PR.

We probably want to do this crate by crate if there are a lot of tests involved that need to be changed.

Additional context

No response

@joshieDo joshieDo added C-enhancement New feature or request S-needs-investigation This issue requires detective work to figure out what's going wrong C-test A change that impacts how or what we test labels Oct 7, 2024
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 29, 2024
@joshieDo joshieDo added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-needs-investigation This issue requires detective work to figure out what's going wrong
Projects
Status: Todo
Development

No branches or pull requests

1 participant