Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate BlockExecutor and TraceExt into one type for RPC #12023

Open
mattsse opened this issue Oct 24, 2024 · 2 comments
Open

Integrate BlockExecutor and TraceExt into one type for RPC #12023

mattsse opened this issue Oct 24, 2024 · 2 comments
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished S-stale This issue/PR is stale and will close with no further activity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 24, 2024

Describe the feature

tracing now is no longer just executing transactions:

#11845

and also now requires system calls which we already have in the BlockExecutor types.

All of this should be integrated into a new rpc tracing specific type that unifies this with the trace and call trait:

reth/crates/rpc/rpc-eth-api/src/helpers/call.rs

Line 657 in 7a06298

fn replay_transactions_until<'a, DB, I>(

reth/crates/rpc/rpc-eth-api/src/helpers/trace.rs

Line 24 in 7a06298

pub trait Trace: LoadState {

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 24, 2024
@mattsse mattsse added S-needs-design This issue requires design work to think about how it would best be accomplished A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Oct 24, 2024
@mattsse mattsse mentioned this issue Oct 26, 2024
Merged
@malik672
Copy link
Contributor

@mattsse can I open a draft for this

@malik672 malik672 mentioned this issue Oct 27, 2024
Open
@klkvr klkvr mentioned this issue Nov 7, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request S-needs-design This issue requires design work to think about how it would best be accomplished S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @malik672